Re: [PATCH 04/51] drm/i915/guc: Implement GuC submission tasklet

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/19/2021 15:55, Matthew Brost wrote:
On Mon, Jul 19, 2021 at 04:01:56PM -0700, John Harrison wrote:
On 7/16/2021 13:16, Matthew Brost wrote:
Implement GuC submission tasklet for new interface. The new GuC
interface uses H2G to submit contexts to the GuC. Since H2G use a single
channel, a single tasklet submits is used for the submission path.
This still needs fixing - 'a single tasklet submits is used' is not valid
English.

Will fix.

It also seems that the idea of splitting all the deletes of old code into a
separate patch didn't happen. It really does obfuscate things significantly
having completely unrelated deletes and adds interspersed :(.

I don't recall promising to do that.

Matt
"No promises but perhaps I'll do this in the next rev."

Well, this is the next rev. So I am expressing my disappointment that it didn't happen. Reviewability of patches is important.

John.

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx



[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux