== Series Details == Series: drm: Make modeset locking easier URL : https://patchwork.freedesktop.org/series/92606/ State : warning == Summary == $ dim checkpatch origin/drm-tip b1e190e95142 drm: Introduce drm_modeset_lock_ctx_retry() -:104: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'ctx' - possible side-effects? #104: FILE: include/drm/drm_modeset_lock.h:221: +#define drm_modeset_lock_ctx_retry(ctx, state, flags, ret) \ + for (_drm_modeset_lock_begin((ctx), (state), (flags), &(ret)); \ + _drm_modeset_lock_loop(&(ret)); \ + _drm_modeset_lock_end((ctx), (state), &(ret))) -:104: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'state' - possible side-effects? #104: FILE: include/drm/drm_modeset_lock.h:221: +#define drm_modeset_lock_ctx_retry(ctx, state, flags, ret) \ + for (_drm_modeset_lock_begin((ctx), (state), (flags), &(ret)); \ + _drm_modeset_lock_loop(&(ret)); \ + _drm_modeset_lock_end((ctx), (state), &(ret))) -:104: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'ret' - possible side-effects? #104: FILE: include/drm/drm_modeset_lock.h:221: +#define drm_modeset_lock_ctx_retry(ctx, state, flags, ret) \ + for (_drm_modeset_lock_begin((ctx), (state), (flags), &(ret)); \ + _drm_modeset_lock_loop(&(ret)); \ + _drm_modeset_lock_end((ctx), (state), &(ret))) total: 0 errors, 0 warnings, 3 checks, 77 lines checked 03c1e97e22ca drm: Introduce drm_modeset_lock_all_ctx_retry() -:32: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'ctx' - possible side-effects? #32: FILE: include/drm/drm_modeset_lock.h:226: +#define drm_modeset_lock_all_ctx_retry(dev, ctx, state, flags, ret) \ + for (_drm_modeset_lock_begin((ctx), (state), (flags), &(ret)); \ + _drm_modeset_lock_loop(&(ret)); \ + _drm_modeset_lock_end((ctx), (state), &(ret))) \ + for_each_if(((ret) = drm_modeset_lock_all_ctx((dev), (ctx))) == 0) -:32: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'state' - possible side-effects? #32: FILE: include/drm/drm_modeset_lock.h:226: +#define drm_modeset_lock_all_ctx_retry(dev, ctx, state, flags, ret) \ + for (_drm_modeset_lock_begin((ctx), (state), (flags), &(ret)); \ + _drm_modeset_lock_loop(&(ret)); \ + _drm_modeset_lock_end((ctx), (state), &(ret))) \ + for_each_if(((ret) = drm_modeset_lock_all_ctx((dev), (ctx))) == 0) -:32: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'ret' - possible side-effects? #32: FILE: include/drm/drm_modeset_lock.h:226: +#define drm_modeset_lock_all_ctx_retry(dev, ctx, state, flags, ret) \ + for (_drm_modeset_lock_begin((ctx), (state), (flags), &(ret)); \ + _drm_modeset_lock_loop(&(ret)); \ + _drm_modeset_lock_end((ctx), (state), &(ret))) \ + for_each_if(((ret) = drm_modeset_lock_all_ctx((dev), (ctx))) == 0) total: 0 errors, 0 warnings, 3 checks, 10 lines checked 0ddd911343c8 drm/i915: Extract intel_crtc_initial_commit() a7ff291d8e28 drm/i915: Use drm_modeset_lock_ctx_retry() & co. _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx