== Series Details == Series: Provide core infrastructure for managing open/release (rev2) URL : https://patchwork.freedesktop.org/series/92556/ State : warning == Summary == $ dim checkpatch origin/drm-tip 55369372f9a3 vfio/samples: Remove module get/put -:55: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Jason Gunthorpe <jgg@xxxxxxxx>' != 'Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 31 lines checked 177714a2be7f vfio: Introduce a vfio_uninit_group_dev() API call a8ad279bbf60 vfio: Provide better generic support for open/release vfio_device_ops -:107: CHECK:BRACES: braces {} should be used on all arms of this statement #107: FILE: drivers/vfio/vfio.c:114: + if (alloc_dev_set) { [...] + } else [...] -:118: CHECK:BRACES: Unbalanced braces around else statement #118: FILE: drivers/vfio/vfio.c:125: + } else -:236: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided #236: FILE: drivers/vfio/vfio.c:1478: + fdno = ret = get_unused_fd_flags(O_CLOEXEC); -:334: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment #334: FILE: include/linux/vfio.h:25: + struct mutex lock; -:376: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Jason Gunthorpe <jgg@xxxxxxxx>' != 'Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxx>' total: 0 errors, 1 warnings, 4 checks, 302 lines checked ec95ddcfb48f vfio/samples: Delete useless open/close -:96: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Jason Gunthorpe <jgg@xxxxxxxx>' != 'Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 66 lines checked 851ba57de6e7 vfio/fsl: Move to the device set infrastructure -:295: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Jason Gunthorpe <jgg@xxxxxxxx>' != 'Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 254 lines checked fceda419b48c vfio/platform: Use open_device() instead of open coding a refcnt scheme -:48: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #48: FILE: drivers/vfio/platform/vfio_platform_common.c:230: + dev_warn( -:102: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #102: FILE: drivers/vfio/platform/vfio_platform_common.c:261: + dev_warn( -:146: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Jason Gunthorpe <jgg@xxxxxxxx>' != 'Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxx>' total: 0 errors, 1 warnings, 2 checks, 120 lines checked 168446e606ea vfio/pci: Move to the device set infrastructure 622d1a17107e vfio/pci: Change vfio_pci_try_bus_reset() to use the dev_set -:130: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #130: FILE: drivers/vfio/pci/vfio_pci.c:2225: + if (vfio_pci_for_each_slot_or_bus( -:236: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Jason Gunthorpe <jgg@xxxxxxxx>' != 'Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxx>' total: 0 errors, 1 warnings, 1 checks, 193 lines checked b2f54bb6af80 vfio/pci: Reorganize VFIO_DEVICE_PCI_HOT_RESET to use the device set -:230: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #230: FILE: drivers/vfio/pci/vfio_pci.c:2103: + if (vfio_pci_for_each_slot_or_bus( -:299: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Jason Gunthorpe <jgg@xxxxxxxx>' != 'Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxx>' total: 0 errors, 1 warnings, 1 checks, 267 lines checked 76aced5ab6ba vfio/mbochs: Fix close when multiple device FDs are open -:35: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Jason Gunthorpe <jgg@xxxxxxxx>' != 'Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 16 lines checked 242842506d4f vfio/ap, ccw: Fix open/close when multiple device FDs are open -:83: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Jason Gunthorpe <jgg@xxxxxxxx>' != 'Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 52 lines checked 4593947ca67f vfio/gvt: Fix open/close when multiple device FDs are open -:50: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Jason Gunthorpe <jgg@xxxxxxxx>' != 'Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 26 lines checked a2014e2a4820 vfio: Remove struct vfio_device_ops open/release -:142: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Jason Gunthorpe <jgg@xxxxxxxx>' != 'Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 107 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
