On Tue, Jul 13, 2021 at 09:44:21PM +0300, Juha-Pekka Heikkila wrote: > skl_compute_plane_wm_params() didn't take into account ccs > modifiers on graphics ver >= 12 > > Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@xxxxxxxxx> > --- > drivers/gpu/drm/i915/intel_pm.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c > index 0cbb79452fcf..540a7ecbf004 100644 > --- a/drivers/gpu/drm/i915/intel_pm.c > +++ b/drivers/gpu/drm/i915/intel_pm.c > @@ -5249,11 +5249,9 @@ skl_compute_wm_params(const struct intel_crtc_state *crtc_state, > > wp->y_tiled = modifier == I915_FORMAT_MOD_Y_TILED || > modifier == I915_FORMAT_MOD_Yf_TILED || > - modifier == I915_FORMAT_MOD_Y_TILED_CCS || > - modifier == I915_FORMAT_MOD_Yf_TILED_CCS; > + is_ccs_modifier(modifier); > wp->x_tiled = modifier == I915_FORMAT_MOD_X_TILED; > - wp->rc_surface = modifier == I915_FORMAT_MOD_Y_TILED_CCS || > - modifier == I915_FORMAT_MOD_Yf_TILED_CCS; > + wp->rc_surface = is_ccs_modifier(modifier); This sets rc_surface for MC modifiers as well. Doesn't matter atm, because it's only used for a GEN 9 workaround, but better to keep it consistent. > wp->is_planar = intel_format_info_is_yuv_semiplanar(format, modifier); > > wp->width = width; > -- > 2.28.0 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx