== Series Details == Series: Get stepping info from RUNTIME_INFO->step URL : https://patchwork.freedesktop.org/series/92346/ State : warning == Summary == $ dim checkpatch origin/drm-tip c109c3b789aa drm/i915: Make pre-production detection use direct revid comparison 8ad43b5ade6f drm/i915/skl: Use revid->stepping tables -:54: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'p' - possible side-effects? #54: FILE: drivers/gpu/drm/i915/i915_drv.h:1512: +#define IS_SKL_GT_STEP(p, since, until) (IS_SKYLAKE(p) && IS_GT_STEP(p, since, until)) total: 0 errors, 0 warnings, 1 checks, 85 lines checked daee55a59631 drm/i915/icl: Use revid->stepping tables -:93: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'p' - possible side-effects? #93: FILE: drivers/gpu/drm/i915/i915_drv.h:1519: +#define IS_ICL_GT_STEP(p, since, until) \ + (IS_ICELAKE(p) && IS_GT_STEP(p, since, until)) total: 0 errors, 0 warnings, 1 checks, 94 lines checked 2f61797e047b drm/i915/jsl_ehl: Use revid->stepping tables -:51: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'p' - possible side-effects? #51: FILE: drivers/gpu/drm/i915/i915_drv.h:1522: +#define IS_JSL_EHL_GT_STEP(p, since, until) \ + (IS_JSL_EHL(p) && IS_GT_STEP(p, since, until)) -:53: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'p' - possible side-effects? #53: FILE: drivers/gpu/drm/i915/i915_drv.h:1524: +#define IS_JSL_EHL_DISPLAY_STEP(p, since, until) \ + (IS_JSL_EHL(p) && IS_DISPLAY_STEP(p, since, until)) total: 0 errors, 0 warnings, 2 checks, 51 lines checked 95363c8b9dc9 drm/i915/rkl: Use revid->stepping tables -:48: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'p' - possible side-effects? #48: FILE: drivers/gpu/drm/i915/i915_drv.h:1539: +#define IS_RKL_DISPLAY_STEP(p, since, until) \ + (IS_ROCKETLAKE(p) && IS_DISPLAY_STEP(p, since, until)) total: 0 errors, 0 warnings, 1 checks, 51 lines checked da4af914b48b drm/i915/dg1: Use revid->stepping tables -:124: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'p' - possible side-effects? #124: FILE: drivers/gpu/drm/i915/i915_drv.h:1533: +#define IS_DG1_GT_STEP(p, since, until) \ + (IS_DG1(p) && IS_GT_STEP(p, since, until)) -:126: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'p' - possible side-effects? #126: FILE: drivers/gpu/drm/i915/i915_drv.h:1535: +#define IS_DG1_DISPLAY_STEP(p, since, until) \ + (IS_DG1(p) && IS_DISPLAY_STEP(p, since, until)) total: 0 errors, 0 warnings, 2 checks, 118 lines checked 2bc809b73f67 drm/i915/cnl: Drop all workarounds 5b936277263e drm/i915/bxt: Use revid->stepping tables de45975f5a75 drm/i915/step: Add intel_step_name() helper -:22: ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line #22: FILE: drivers/gpu/drm/i915/intel_step.c:186: +const char *intel_step_name(enum intel_step step) { -:26: WARNING:UNNECESSARY_BREAK: break is not useful after a return #26: FILE: drivers/gpu/drm/i915/intel_step.c:190: + return "A0"; + break; -:29: WARNING:UNNECESSARY_BREAK: break is not useful after a return #29: FILE: drivers/gpu/drm/i915/intel_step.c:193: + return "A1"; + break; -:32: WARNING:UNNECESSARY_BREAK: break is not useful after a return #32: FILE: drivers/gpu/drm/i915/intel_step.c:196: + return "A2"; + break; -:35: WARNING:UNNECESSARY_BREAK: break is not useful after a return #35: FILE: drivers/gpu/drm/i915/intel_step.c:199: + return "B0"; + break; -:38: WARNING:UNNECESSARY_BREAK: break is not useful after a return #38: FILE: drivers/gpu/drm/i915/intel_step.c:202: + return "B1"; + break; -:41: WARNING:UNNECESSARY_BREAK: break is not useful after a return #41: FILE: drivers/gpu/drm/i915/intel_step.c:205: + return "B2"; + break; -:44: WARNING:UNNECESSARY_BREAK: break is not useful after a return #44: FILE: drivers/gpu/drm/i915/intel_step.c:208: + return "C0"; + break; -:47: WARNING:UNNECESSARY_BREAK: break is not useful after a return #47: FILE: drivers/gpu/drm/i915/intel_step.c:211: + return "C1"; + break; -:50: WARNING:UNNECESSARY_BREAK: break is not useful after a return #50: FILE: drivers/gpu/drm/i915/intel_step.c:214: + return "D0"; + break; -:53: WARNING:UNNECESSARY_BREAK: break is not useful after a return #53: FILE: drivers/gpu/drm/i915/intel_step.c:217: + return "D1"; + break; -:56: WARNING:UNNECESSARY_BREAK: break is not useful after a return #56: FILE: drivers/gpu/drm/i915/intel_step.c:220: + return "E0"; + break; -:59: WARNING:UNNECESSARY_BREAK: break is not useful after a return #59: FILE: drivers/gpu/drm/i915/intel_step.c:223: + return "F0"; + break; -:62: WARNING:UNNECESSARY_BREAK: break is not useful after a return #62: FILE: drivers/gpu/drm/i915/intel_step.c:226: + return "G0"; + break; -:65: WARNING:UNNECESSARY_BREAK: break is not useful after a return #65: FILE: drivers/gpu/drm/i915/intel_step.c:229: + return "H0"; + break; -:68: WARNING:UNNECESSARY_BREAK: break is not useful after a return #68: FILE: drivers/gpu/drm/i915/intel_step.c:232: + return "I0"; + break; -:71: WARNING:UNNECESSARY_BREAK: break is not useful after a return #71: FILE: drivers/gpu/drm/i915/intel_step.c:235: + return "I1"; + break; -:74: WARNING:UNNECESSARY_BREAK: break is not useful after a return #74: FILE: drivers/gpu/drm/i915/intel_step.c:238: + return "J0"; + break; total: 1 errors, 17 warnings, 0 checks, 67 lines checked 2ecb4107afb2 drm/i915/dmc: Modify intel_get_stepping_info() -:72: ERROR:CODE_INDENT: code indent should use tabs where possible #72: FILE: drivers/gpu/drm/i915/display/intel_dmc.c:258: + si->substepping = step_name[1];$ -:72: WARNING:LEADING_SPACE: please, no spaces at the start of a line #72: FILE: drivers/gpu/drm/i915/display/intel_dmc.c:258: + si->substepping = step_name[1];$ total: 1 errors, 1 warnings, 0 checks, 66 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
