== Series Details == Series: drm/sched dependency tracking and dma-resv fixes (rev2) URL : https://patchwork.freedesktop.org/series/92333/ State : warning == Summary == $ dim checkpatch origin/drm-tip aa63f4780928 drm/sched: entity->rq selection cannot fail -:52: WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON() #52: FILE: drivers/gpu/drm/scheduler/sched_main.c:584: + BUG_ON(!entity->rq); -:55: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Daniel Vetter <daniel.vetter@xxxxxxxx>' != 'Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>' total: 0 errors, 2 warnings, 0 checks, 17 lines checked 3afe40cffa3e drm/sched: Split drm_sched_job_init -:205: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #205: FILE: drivers/gpu/drm/scheduler/sched_fence.c:173: + unsigned seq; -:284: WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON() #284: FILE: drivers/gpu/drm/scheduler/sched_main.c:614: + BUG_ON(!entity); -:365: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #365: FILE: include/drm/gpu_scheduler.h:391: +struct drm_sched_fence *drm_sched_fence_alloc( -:373: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Daniel Vetter <daniel.vetter@xxxxxxxx>' != 'Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>' total: 0 errors, 3 warnings, 1 checks, 235 lines checked 998b636c6f3c drm/sched: Barriers are needed for entity->last_scheduled -:86: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Daniel Vetter <daniel.vetter@xxxxxxxx>' != 'Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 43 lines checked 2554ae9762d1 drm/sched: Add dependency tracking -:193: CHECK:LINE_SPACING: Please don't use multiple blank lines #193: FILE: drivers/gpu/drm/scheduler/sched_main.c:722: + + -:268: WARNING:TYPO_SPELLING: 'ommitted' may be misspelled - perhaps 'omitted'? #268: FILE: include/drm/gpu_scheduler.h:243: + * drm_sched_job_await_implicit() this can be ommitted and left as NULL. ^^^^^^^^ -:282: CHECK:LINE_SPACING: Please don't use multiple blank lines #282: FILE: include/drm/gpu_scheduler.h:376: + + -:285: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Daniel Vetter <daniel.vetter@xxxxxxxx>' != 'Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>' total: 0 errors, 2 warnings, 2 checks, 227 lines checked 6f8a6dac8300 drm/sched: drop entity parameter from drm_sched_push_job -:203: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Daniel Vetter <daniel.vetter@xxxxxxxx>' != 'Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 102 lines checked f46108672694 drm/sched: improve docs around drm_sched_entity -:14: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 620e762f9a98 ("drm/scheduler: move entity handling into separate file")' #14: move here: 620e762f9a98 ("drm/scheduler: move entity handling into -:396: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Daniel Vetter <daniel.vetter@xxxxxxxx>' != 'Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>' total: 1 errors, 1 warnings, 0 checks, 346 lines checked dca5c513ac3d drm/panfrost: use scheduler dependency tracking -:209: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Daniel Vetter <daniel.vetter@xxxxxxxx>' != 'Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 157 lines checked a51bbbac956b drm/lima: use scheduler dependency tracking -:114: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Daniel Vetter <daniel.vetter@xxxxxxxx>' != 'Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 73 lines checked 34e837ac1d7b drm/v3d: Move drm_sched_job_init to v3d_job_init -:356: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Daniel Vetter <daniel.vetter@xxxxxxxx>' != 'Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 302 lines checked d4fa82c9c97f drm/v3d: Use scheduler dependency handling -:202: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Daniel Vetter <daniel.vetter@xxxxxxxx>' != 'Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 161 lines checked 5e34a7c752a3 drm/etnaviv: Use scheduler dependency handling -:13: WARNING:REPEATED_WORD: Possible repeated word: 'to' #13: I wanted to to in the previous round (and did, for all other drivers). -:119: WARNING:LINE_SPACING: Missing a blank line after declarations #119: FILE: drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c:551: + struct dma_fence *in_fence = sync_file_get_fence(args->fence_fd); + if (!in_fence) { -:293: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Daniel Vetter <daniel.vetter@xxxxxxxx>' != 'Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>' total: 0 errors, 3 warnings, 0 checks, 241 lines checked 28feb868173e drm/gem: Delete gem array fencing helpers -:141: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Daniel Vetter <daniel.vetter@xxxxxxxx>' != 'Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 14 lines checked 588331541d89 drm/sched: Don't store self-dependencies -:19: WARNING:TYPO_SPELLING: 'wont' may be misspelled - perhaps 'won't'? #19: drivers wont miss it. ^^^^ -:47: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Daniel Vetter <daniel.vetter@xxxxxxxx>' != 'Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>' total: 0 errors, 2 warnings, 0 checks, 13 lines checked 6219e79695d6 drm/sched: Check locking in drm_sched_job_await_implicit -:33: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Daniel Vetter <daniel.vetter@xxxxxxxx>' != 'Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 8 lines checked b149f2ca5c3f drm/msm: Don't break exclusive fence ordering -:43: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Daniel Vetter <daniel.vetter@xxxxxxxx>' != 'Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 9 lines checked 9e395399b983 drm/msm: always wait for the exclusive fence -:9: WARNING:REPEATED_WORD: Possible repeated word: 'to' #9: Drivers also need to to sync to the exclusive fence when -:39: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'fence->context != fctx->context' #39: FILE: drivers/gpu/drm/msm/msm_gem.c:817: + if (fence && (fence->context != fctx->context)) { -:48: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: "Christian König" <ckoenig.leichtzumerken@xxxxxxxxx>' != 'Signed-off-by: Christian König <christian.koenig@xxxxxxx>' total: 0 errors, 2 warnings, 1 checks, 24 lines checked d022184c169b drm/etnaviv: Don't break exclusive fence ordering -:20: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #20: https://lore.kernel.org/dri-devel/20210610210925.642582-7-jason@xxxxxxxxxxxxxx/ -:57: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Daniel Vetter <daniel.vetter@xxxxxxxx>' != 'Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>' total: 0 errors, 2 warnings, 0 checks, 23 lines checked 56fc78cd5073 drm/i915: delete exclude argument from i915_sw_fence_await_reservation -:12: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit d07f0e59b2c7 ("drm/i915: Move GEM activity tracking into a common struct reservation_object")' #12: commit d07f0e59b2c762584478920cd2d11fba2980a94a -:113: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Daniel Vetter <daniel.vetter@xxxxxxxx>' != 'Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>' total: 1 errors, 1 warnings, 0 checks, 63 lines checked 10b231f895fe drm/i915: Don't break exclusive fence ordering -:23: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #23: https://lore.kernel.org/dri-devel/20210610210925.642582-7-jason@xxxxxxxxxxxxxx/ -:56: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Daniel Vetter <daniel.vetter@xxxxxxxx>' != 'Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>' total: 0 errors, 2 warnings, 0 checks, 18 lines checked ca32cb2b56ef dma-resv: Give the docs a do-over -:290: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Daniel Vetter <daniel.vetter@xxxxxxxx>' != 'Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 216 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
