Re: [PATCH 3/4] Klock work Fix for possible memory leak in intel_execlists_submission.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 28/06/2021 15:38, Bommu Krishnaiah wrote:
Signed-off-by: Bommu Krishnaiah <krishnaiah.bommu@xxxxxxxxx>
Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
---
  drivers/gpu/drm/i915/gt/intel_execlists_submission.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/i915/gt/intel_execlists_submission.c b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c
index cdb2126a159a8..a4673900af0e0 100644
--- a/drivers/gpu/drm/i915/gt/intel_execlists_submission.c
+++ b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c
@@ -3847,6 +3847,7 @@ intel_execlists_create_virtual(struct intel_engine_cs **siblings,
err_put:
  	intel_context_put(&ve->context);
+	kfree(ve);
  	return ERR_PTR(err);
  }
It looks like a false positive to me because it is already freed:

intel_context_put(&ve->context)
  -> rcu_virtual_context_destroy
       -> kfree(ve)

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx



[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux