Re: [PATCH 14/15] drm/gem: Tiny kernel clarification for drm_gem_fence_array_add

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





Am 24.06.21 um 14:41 schrieb Daniel Vetter:
On Wed, Jun 23, 2021 at 10:42:50AM +0200, Christian König wrote:
Am 22.06.21 um 18:55 schrieb Daniel Vetter:
Spotted while trying to convert panfrost to these.

Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>
Cc: "Christian König" <christian.koenig@xxxxxxx>
Cc: Lucas Stach <l.stach@xxxxxxxxxxxxxx>
Cc: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>
Cc: Maxime Ripard <mripard@xxxxxxxxxx>
Cc: Thomas Zimmermann <tzimmermann@xxxxxxx>
Cc: David Airlie <airlied@xxxxxxxx>
Cc: Daniel Vetter <daniel@xxxxxxxx>
---
   drivers/gpu/drm/drm_gem.c | 3 +++
   1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
index ba2e64ed8b47..68deb1de8235 100644
--- a/drivers/gpu/drm/drm_gem.c
+++ b/drivers/gpu/drm/drm_gem.c
@@ -1302,6 +1302,9 @@ EXPORT_SYMBOL(drm_gem_unlock_reservations);
    * @fence_array: array of dma_fence * for the job to block on.
    * @fence: the dma_fence to add to the list of dependencies.
    *
+ * This functions consumes the reference for @fence both on success and error
+ * cases.
+ *
Oh, the later is a bit ugly I think. But good to know.

Reviewed-by: Christian König <christian.koenig@xxxxxxx>
Merged to drm-misc-next, thanks for taking a look. Can you perhaps take a
look at the drm/armada patch too, then I think I have reviews/acks for all
of them?

What are you talking about? I only see drm/armada patches for the irq stuff Thomas is working on.

Christian.


Thanks, Daniel

    * Returns:
    * 0 on success, or an error on failing to expand the array.
    */

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux