On Tue, 2021-06-08 at 10:26 +0300, Ville Syrjälä wrote: > On Fri, May 14, 2021 at 04:22:47PM -0700, José Roberto de Souza wrote: > > intel_dp_set_infoframes() call in intel_ddi_post_disable_dp() will > > take care to disable all enabled infoframes. > > > > Cc: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > Signed-off-by: José Roberto de Souza <jose.souza@xxxxxxxxx> > > --- > > drivers/gpu/drm/i915/display/intel_ddi.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c > > index 5bc5528f3091..d3bc5a1a936a 100644 > > --- a/drivers/gpu/drm/i915/display/intel_ddi.c > > +++ b/drivers/gpu/drm/i915/display/intel_ddi.c > > @@ -2762,7 +2762,6 @@ static void intel_ddi_pre_enable(struct intel_atomic_state *state, > > conn_state); > > > > /* FIXME precompute everything properly */ > > - /* FIXME how do we turn infoframes off again? */ > > The FIXME was there for LSPCON and shouldn't have been removed. > No one has yet figured out how to do this. intel_ddi_post_disable_dp()->intel_dp_set_infoframes() will be executed for LSPCON, or am I missing something? > > > if (dig_port->lspcon.active && dig_port->dp.has_hdmi_sink) > > dig_port->set_infoframes(encoder, true, crtc_state, > > conn_state); > > -- > > 2.31.1 > _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
