On Tue, Jun 01, 2021 at 01:39:25PM -0700, Matt Roper wrote:
On Tue, Jun 01, 2021 at 12:13:17PM -0700, Lucas De Marchi wrote:
On Tue, Jun 01, 2021 at 10:30:55AM -0700, Matt Roper wrote:
> On Tue, Jun 01, 2021 at 10:15:14AM -0700, Lucas De Marchi wrote:
> > On Tue, Jun 01, 2021 at 09:58:34AM -0700, Matt Roper wrote:
> > > On Thu, May 27, 2021 at 11:16:54AM -0700, Lucas De Marchi wrote:
> > > > This was done by the following semantic patch:
> > >
> > > Is the commit message here out-of-date? The cocci doesn't appear to
> > > match the diff anymore. IS_GRAPHICS_VER() is the range macro now and
> > > IS_GEN is being replaced with a direct "==" comparison.
> >
> > not necessarily, it's included in "and friends...". Maybe rewording to
> > something like "replace gen-based macros with new ver-based ones" would
> > make it clearer?
>
> I mean that running the coccinelle rules below through spatch won't
> generate the code diff here; it would generate a completely different
> patch (that I don't think would build properly either).
oh, ok. I fixed the issues in the .cocci and forgot to update the commit
message. Thanks.
Lucas De Marchi
Aside from the commit messages needing updated Coccinelle rules, the
code deltas look correct to me.
Reviewed-by: Matt Roper <matthew.d.roper@xxxxxxxxx>
humn... is that to the series or only this commit?
Lucas De Marchi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
