Thank you so much Petri. Apologies for the incorrect commit message. I will submit the patch with the clear commit message. Regards Vidya -----Original Message----- From: Latvala, Petri <petri.latvala@xxxxxxxxx> Sent: Tuesday, June 1, 2021 7:11 PM To: Srinivas, Vidya <vidya.srinivas@xxxxxxxxx> Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx; igt-dev@xxxxxxxxxxxxxxxxxxxxx Subject: Re: [igt-dev] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests On Tue, Jun 01, 2021 at 05:15:39PM +0530, Vidya Srinivas wrote: > tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests > > Few Gen11 systems show CRC mismatch. Make > coverage-vs-premult-vs-constant code similar to constant_alpha_min or > basic_alpha > > Signed-off-by: Vidya Srinivas <vidya.srinivas@xxxxxxxxx> Please make the first line of the commit message a statement that tells what change you're making, and in the full text block state why that's done. "Fix a-b-c tests" is useless later when browsing oneliner git logs. It doesn't even tell which problem is fixed. Meaning, something like: == tests/kms_plane_alpha_blend: Don't set primary fb color in coverage-vs-premult-vs-constant Similar change has already been done in tests xxx and yyy. This fixes CRC mismatches seen with some Gen11 systems. Signed-off-by etc == -- Petri Latvala _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
