On Thu, Apr 11, 2013 at 02:47:05PM -0300, Paulo Zanoni wrote: > Hi > > 2013/4/11 Daniel Vetter <daniel.vetter at ffwll.ch>: > > Just blows through 50ms for naught, since the pipe is off. > > > > Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch> > > Looks correct, but can you also please add some WARNs in case the pipe > is actually on? Check haswell_crtc_mode_set for examples: > > - WARN_ON(I915_READ(PIPECONF(intel_crtc->cpu_transcoder)) & > (PIPECONF_ENABLE | I965_PIPECONF_ACTIVE)); > - WARN_ON(I915_READ(DSPCNTR(plane)) & DISPLAY_PLANE_ENABLE); We have _tons_ of assert_pipe_disabled in the enable/disable sequence for i9xx now. So I think we're covered. On that topic: Can't we use the same macros for the Haswell code? Would make things a bit more readable imo ... -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
