On Sat, May 15, 2021 at 12:23:04AM +0000, Souza, Jose wrote: > On Fri, 2021-05-14 at 07:49 +0200, Christoph Hellwig wrote: > > On Thu, May 13, 2021 at 04:28:41PM -0700, José Roberto de Souza wrote: > > > If the do while loop breaks in 'if (!sg_dma_len(sgl))' in the first > > > iteration, err is uninitialized causing a wrong call to zap_vma_ptes(). > > > > But scatterlist must have at least one valid segment. So while the > > patch looks ok, please clearly mark that this is a false positive from > > the static checker in the commit log. > > No static checker mentioned but yes it was caught by one. > Anyways better have this change and avoid possible reports from other static analyzers. Please also add the information I provided above to put this into context. > > Can I add your Reviewed-by? With that: Reviewed-by: Christoph Hellwig <hch@xxxxxx> _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
