> -----Original Message----- > From: Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx> > Sent: Tuesday, May 4, 2021 11:41 PM > To: Srivatsa, Anusha <anusha.srivatsa@xxxxxxxxx>; intel- > gfx@xxxxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH 0/3] Pipe DMC Prep patches > > On Mon, 03 May 2021, Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx> wrote: > > On Wed, 28 Apr 2021, Anusha Srivatsa <anusha.srivatsa@xxxxxxxxx> > wrote: > >> This series adds the prep work needed before the actual Pipe DMC > >> implementation. > > > > When should we rename csr to dmc all over the place? > > To elaborate, I think it's pretty confusing that we use both CSR and DMC > acronyms in code. There may be a distinction, but we don't respect that in > the usage. Sure, the spec mentions both, but I don't think we follow the > naming there either. > > I think we should just rename all CSR references to DMC, including the file > name and the function and struct names. > Just eyeballing the source file, it looks like it is a good way to go. We have function names like parse_csr_fw_dmc which can be changed to just parse_dmc_fw_header or something on those lines... > I wonder if it would be better to do the renames first before starting to build > a lot of changes on top. Yes. The renames will affect some things that this series touches as well. Anusha > BR, > Jani. > > > -- > Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
