On Wed, 21 Apr 2021, Ville Syrjala <ville.syrjala@xxxxxxxxxxxxxxx> wrote:
> From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
>
> The DDI buf trans functions keep turning into bad
> spaghetti every time a new platform gets added.
> Split the platforms up properly and turn the whole
> thing into a vfunc to make it easier to manage
> multiple platforms.
One of the most wanted refactoring series I've seen in a while!
I haven't reviewed it, but I've glanced through it all. Almost started
nitpicking about some function naming early on, but realized they were
made static later in the series. Overall looked like good stuff.
Acked-by: Jani Nikula <jani.nikula@xxxxxxxxx>
>
> Ville Syrjälä (17):
> drm/i915: s/intel/hsw/ for hsw/bde/skl buf trans
> drm/i915: Introduce hsw_get_buf_trans()
> drm/i915: Wrap the platform specific buf trans structs into a union
> drm/i915: Rename dkl phy buf trans tables
> drm/i915: Wrap the buf trans tables into a struct
> drm/i915: Introduce intel_get_buf_trans()
> drm/i915; Return the whole buf_trans struct from get_buf_trans()
^
Here's one review comment. ;)
> drm/i915: Store the HDMI default entry in the bug trans struct
> drm/i915: Introduce encoder->get_buf_trans()
> drm/i915: Clean up hsw/bdw/skl/kbl buf trans funcs
> drm/i915: Introduce rkl_get_combo_buf_trans()
> drm/i915: Fix dg1 buf trans tables
> drm/i915: Deduplicate icl DP HBR2 vs. eDP HBR3 table
> drm/i915: Fix ehl edp hbr2 vswing table
> drm/i915: Clean up jsl/ehl buf trans functions
> drm/i915: Nuke buf_trans hdmi functions
> drm/i915: Add the missing adls vswing tables
>
> drivers/gpu/drm/i915/display/intel_crt.c | 3 +
> drivers/gpu/drm/i915/display/intel_ddi.c | 162 +-
> drivers/gpu/drm/i915/display/intel_ddi.h | 4 +-
> .../drm/i915/display/intel_ddi_buf_trans.c | 2354 ++++++++++-------
> .../drm/i915/display/intel_ddi_buf_trans.h | 63 +-
> .../drm/i915/display/intel_display_types.h | 4 +
> drivers/gpu/drm/i915/display/intel_fdi.c | 5 +-
> 7 files changed, 1432 insertions(+), 1163 deletions(-)
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
