On Fri, 05 Apr 2013, Ben Widawsky <ben at bwidawsk.net> wrote: > On Fri, Apr 05, 2013 at 10:09:58AM +0300, Jani Nikula wrote: >> Same goes for the unlikely in patches 4/7. (Yes, patch_es_ 4/7 - there's >> *two* patches 4/7 in the series! :o) > > I don't see two, weird. Hmm, it's not only my mail setup: http://thread.gmane.org/gmane.comp.freedesktop.xorg.drivers.intel/20106/focus=20108 >> I'm just generally wary of adding (un)likely annotations. I don't think >> it matters that the annotation itself is obviously correct; IMHO the >> performance impact should matter. >> >> </bikeshed> > > Right. I actually stuck it in by accident, and decided to keep it only > because it serves as nice documentation. I suppose a comment would do > the same thing, but this also had a chance (albeit slight) to improve > things. That's true too, and I do like code that documents itself. No biggie. BR, Jani.
