On Fri, 23 Apr 2021, Lionel Landwerlin <lionel.g.landwerlin@xxxxxxxxx> wrote:
> On 21/04/2021 20:28, Umesh Nerlige Ramappa wrote:
>> +static int
>> +query_cs_cycles(struct drm_i915_private *i915,
>> + struct drm_i915_query_item *query_item)
>> +{
>> + struct drm_i915_query_cs_cycles __user *query_ptr;
>> + struct drm_i915_query_cs_cycles query;
>> + struct intel_engine_cs *engine;
>> + __ktime_func_t cpu_clock;
>> + int ret;
>> +
>> + if (INTEL_GEN(i915) < 6)
>> + return -ENODEV;
>> +
[...]
>> +
>> + if (IS_GEN(i915, 6) &&
>> + query.engine.engine_class != I915_ENGINE_CLASS_RENDER)
>> + return -ENODEV;
>
>
> Thanks a bunch for rebasing this.
>
> My only comment on this patch would be : don't we want
> IS_GEN_RANGE(i915, 1, 6) instead of IS_GEN(i915, 6) ?
Please see the new deprecation comments in i915_drv.h. We're moving from
GEN to VER. In short, please use the new VER macros for individual
components instead of the generic GEN.
Thanks,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
