On Thu, Mar 25, 2021 at 11:06:59AM -0700, Matt Roper wrote: > From: José Roberto de Souza <jose.souza@xxxxxxxxx> > > Alderlake P have modular FIA like TGL but it is always modular in all > skus, not like TGL that we had to read a register to check if it is > monolithic or modular. > > BSpec: 55480 > BSpec: 50572 > Cc: Imre Deak <imre.deak@xxxxxxxxx> > Signed-off-by: José Roberto de Souza <jose.souza@xxxxxxxxx> > Signed-off-by: Clinton Taylor <Clinton.A.Taylor@xxxxxxxxx> > Signed-off-by: Matt Roper <matthew.d.roper@xxxxxxxxx> Reviewed-by: Imre Deak <imre.deak@xxxxxxxxx> > --- > drivers/gpu/drm/i915/display/intel_tc.c | 4 ++++ > drivers/gpu/drm/i915/i915_pci.c | 1 + > 2 files changed, 5 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_tc.c b/drivers/gpu/drm/i915/display/intel_tc.c > index 7bae0193aa0f..8f60a94852f3 100644 > --- a/drivers/gpu/drm/i915/display/intel_tc.c > +++ b/drivers/gpu/drm/i915/display/intel_tc.c > @@ -734,6 +734,10 @@ tc_has_modular_fia(struct drm_i915_private *i915, struct intel_digital_port *dig > if (!INTEL_INFO(i915)->display.has_modular_fia) > return false; > > + /* TODO: check if in real HW MODULAR_FIA_MASK is set, if so remove this block */ > + if (IS_ALDERLAKE_P(i915)) > + return true; > + > wakeref = tc_cold_block(dig_port); > val = intel_uncore_read(&i915->uncore, PORT_TX_DFLEXDPSP(FIA1)); > tc_cold_unblock(dig_port, wakeref); > diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c > index 1ceb3cd4068d..39cbfdf7c50e 100644 > --- a/drivers/gpu/drm/i915/i915_pci.c > +++ b/drivers/gpu/drm/i915/i915_pci.c > @@ -951,6 +951,7 @@ static const struct intel_device_info adl_p_info = { > XE_LPD_FEATURES, > PLATFORM(INTEL_ALDERLAKE_P), > .require_force_probe = 1, > + .display.has_modular_fia = 1, > .platform_engine_mask = > BIT(RCS0) | BIT(BCS0) | BIT(VECS0) | BIT(VCS0) | BIT(VCS2), > .ppgtt_size = 48, > -- > 2.25.4 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx