Re: [PATCH] [v2] drm/i915: Remove repeated declaration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2021-03-26 at 09:25 +0800, Wan Jiabing wrote:
> struct drm_i915_private, struct intel_crtc_state and
> struct intel_crtc is declared twice.
> Remove the duplicate.
> 

LGTM, thanks for renaming, after CI results will push it for you.

> Reviewed-by: José Roberto de Souza <jose.souza@xxxxxxxxx>
> Signed-off-by: Wan Jiabing <wanjiabing@xxxxxxxx>
> ---
> Changelog:
> v2:
> - Modify subject line.
> - Delete trailing whitespace in commit log.
> ---
>  drivers/gpu/drm/i915/display/intel_crt.h     | 1 -
>  drivers/gpu/drm/i915/display/intel_display.h | 1 -
>  drivers/gpu/drm/i915/display/intel_vrr.h     | 1 -
>  3 files changed, 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_crt.h b/drivers/gpu/drm/i915/display/intel_crt.h
> index 1b3fba359efc..6c5c44600cbd 100644
> --- a/drivers/gpu/drm/i915/display/intel_crt.h
> +++ b/drivers/gpu/drm/i915/display/intel_crt.h
> @@ -11,7 +11,6 @@
>  enum pipe;
>  struct drm_encoder;
>  struct drm_i915_private;
> -struct drm_i915_private;
>  
> 
> 
> 
>  bool intel_crt_port_enabled(struct drm_i915_private *dev_priv,
>  			    i915_reg_t adpa_reg, enum pipe *pipe);
> diff --git a/drivers/gpu/drm/i915/display/intel_display.h b/drivers/gpu/drm/i915/display/intel_display.h
> index 76f8a805b0a3..29cb6d84ed70 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.h
> +++ b/drivers/gpu/drm/i915/display/intel_display.h
> @@ -48,7 +48,6 @@ struct i915_ggtt_view;
>  struct intel_atomic_state;
>  struct intel_crtc;
>  struct intel_crtc_state;
> -struct intel_crtc_state;
>  struct intel_digital_port;
>  struct intel_dp;
>  struct intel_encoder;
> diff --git a/drivers/gpu/drm/i915/display/intel_vrr.h b/drivers/gpu/drm/i915/display/intel_vrr.h
> index fac01bf4ab50..96f9c9c27ab9 100644
> --- a/drivers/gpu/drm/i915/display/intel_vrr.h
> +++ b/drivers/gpu/drm/i915/display/intel_vrr.h
> @@ -15,7 +15,6 @@ struct intel_crtc;
>  struct intel_crtc_state;
>  struct intel_dp;
>  struct intel_encoder;
> -struct intel_crtc;
>  
> 
> 
> 
>  bool intel_vrr_is_capable(struct drm_connector *connector);
>  void intel_vrr_check_modeset(struct intel_atomic_state *state);

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux