== Series Details == Series: drm/i915: refactor KBL/TGL/ADLS stepping scheme (rev3) URL : https://patchwork.freedesktop.org/series/87323/ State : warning == Summary == $ dim checkpatch origin/drm-tip 879114240a25 drm/i915: split out stepping info to a new file -:124: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #124: new file mode 100644 total: 0 errors, 1 warnings, 0 checks, 162 lines checked a158a630e648 drm/i915: add new helpers for accessing stepping info -:36: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i915' - possible side-effects? #36: FILE: drivers/gpu/drm/i915/i915_drv.h:1274: +#define IS_DISPLAY_STEP(__i915, since, until) \ + (drm_WARN_ON(&(__i915)->drm, INTEL_DISPLAY_STEP(__i915) == STEP_NONE), \ + INTEL_DISPLAY_STEP(__i915) >= (since) && INTEL_DISPLAY_STEP(__i915) <= (until)) -:40: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i915' - possible side-effects? #40: FILE: drivers/gpu/drm/i915/i915_drv.h:1278: +#define IS_GT_STEP(__i915, since, until) \ + (drm_WARN_ON(&(__i915)->drm, INTEL_GT_STEP(__i915) == STEP_NONE), \ + INTEL_GT_STEP(__i915) >= (since) && INTEL_GT_STEP(__i915) <= (until)) total: 0 errors, 0 warnings, 2 checks, 66 lines checked c4a274f64cda drm/i915: switch KBL to the new stepping scheme -:114: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev_priv' - possible side-effects? #114: FILE: drivers/gpu/drm/i915/i915_drv.h:1469: +#define IS_KBL_GT_STEP(dev_priv, since, until) \ + (IS_KABYLAKE(dev_priv) && IS_GT_STEP(dev_priv, since, until)) -:116: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev_priv' - possible side-effects? #116: FILE: drivers/gpu/drm/i915/i915_drv.h:1471: +#define IS_KBL_DISPLAY_STEP(dev_priv, since, until) \ + (IS_KABYLAKE(dev_priv) && IS_DISPLAY_STEP(dev_priv, since, until)) -:157: CHECK:LINE_SPACING: Please don't use multiple blank lines #157: FILE: drivers/gpu/drm/i915/intel_step.c:16: + total: 0 errors, 0 warnings, 3 checks, 198 lines checked 3dce1f7cf58b drm/i915: switch TGL and ADL to the new stepping scheme -:58: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i915' - possible side-effects? #58: FILE: drivers/gpu/drm/i915/i915_drv.h:1504: +#define IS_TGL_DISP_STEPPING(__i915, since, until) \ + (IS_TIGERLAKE(__i915) && \ + IS_DISPLAY_STEP(__i915, since, until)) -:66: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i915' - possible side-effects? #66: FILE: drivers/gpu/drm/i915/i915_drv.h:1508: +#define IS_TGL_UY_GT_STEPPING(__i915, since, until) \ + ((IS_TGL_U(__i915) || IS_TGL_Y(__i915)) && \ + IS_GT_STEP(__i915, since, until)) -:75: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i915' - possible side-effects? #75: FILE: drivers/gpu/drm/i915/i915_drv.h:1512: +#define IS_TGL_GT_STEPPING(__i915, since, until) \ + (IS_TIGERLAKE(__i915) && !(IS_TGL_U(__i915) || IS_TGL_Y(__i915)) && \ + IS_GT_STEP(__i915, since, until)) -:89: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i915' - possible side-effects? #89: FILE: drivers/gpu/drm/i915/i915_drv.h:1529: +#define IS_ADLS_DISP_STEPPING(__i915, since, until) \ + (IS_ALDERLAKE_S(__i915) && \ + IS_DISPLAY_STEP(__i915, since, until)) -:97: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i915' - possible side-effects? #97: FILE: drivers/gpu/drm/i915/i915_drv.h:1533: +#define IS_ADLS_GT_STEPPING(__i915, since, until) \ + (IS_ALDERLAKE_S(__i915) && \ + IS_GT_STEP(__i915, since, until)) total: 0 errors, 0 warnings, 5 checks, 127 lines checked a01b77b14b7e drm/i915: rename DISP_STEPPING->DISPLAY_STEP and GT_STEPPING->GT_STEP -:117: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i915' - possible side-effects? #117: FILE: drivers/gpu/drm/i915/i915_drv.h:1504: +#define IS_TGL_DISPLAY_STEP(__i915, since, until) \ (IS_TIGERLAKE(__i915) && \ IS_DISPLAY_STEP(__i915, since, until)) -:122: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i915' - possible side-effects? #122: FILE: drivers/gpu/drm/i915/i915_drv.h:1508: +#define IS_TGL_UY_GT_STEP(__i915, since, until) \ ((IS_TGL_U(__i915) || IS_TGL_Y(__i915)) && \ IS_GT_STEP(__i915, since, until)) -:127: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i915' - possible side-effects? #127: FILE: drivers/gpu/drm/i915/i915_drv.h:1512: +#define IS_TGL_GT_STEP(__i915, since, until) \ (IS_TIGERLAKE(__i915) && !(IS_TGL_U(__i915) || IS_TGL_Y(__i915)) && \ IS_GT_STEP(__i915, since, until)) -:136: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i915' - possible side-effects? #136: FILE: drivers/gpu/drm/i915/i915_drv.h:1529: +#define IS_ADLS_DISPLAY_STEP(__i915, since, until) \ (IS_ALDERLAKE_S(__i915) && \ IS_DISPLAY_STEP(__i915, since, until)) -:141: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i915' - possible side-effects? #141: FILE: drivers/gpu/drm/i915/i915_drv.h:1533: +#define IS_ADLS_GT_STEP(__i915, since, until) \ (IS_ALDERLAKE_S(__i915) && \ IS_GT_STEP(__i915, since, until)) total: 0 errors, 0 warnings, 5 checks, 117 lines checked cf5108b09da1 drm/i915: rename disp_stepping->display_step and gt_stepping->gt_step 505e061b09f9 drm/i915: rename i915_rev_steppings->intel_step_info _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx