== Series Details == Series: drm/i915: Remove obj->mm.lock! (rev18) URL : https://patchwork.freedesktop.org/series/82337/ State : warning == Summary == $ dim checkpatch origin/drm-tip 21e30af84d60 drm/i915: Do not share hwsp across contexts any more, v8. -:565: WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test #565: FILE: drivers/gpu/drm/i915/gt/intel_timeline.c:286: + if (TIMELINE_SEQNO_BYTES <= BIT(5) && (next_ofs & BIT(5))) total: 0 errors, 1 warnings, 0 checks, 967 lines checked 3dcc3090a8aa drm/i915: Pin timeline map after first timeline pin, v4. -:16: WARNING:TYPO_SPELLING: 'arithmatic' may be misspelled - perhaps 'arithmetic'? #16: - Fix NULL + XX arithmatic, use casts. (kbuild) ^^^^^^^^^^ total: 0 errors, 1 warnings, 0 checks, 288 lines checked 61e73e406004 drm/i915: Move cmd parser pinning to execbuffer 263d87a59478 drm/i915: Add missing -EDEADLK handling to execbuf pinning, v2. -:59: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #59: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:452: + err = i915_vma_pin_ww(vma, &eb->ww, entry->pad_to_size, total: 0 errors, 0 warnings, 1 checks, 75 lines checked d0fd03b71eac drm/i915: Ensure we hold the object mutex in pin correctly. 5f9f5fded601 drm/i915: Add gem object locking to madvise. ec224070faa9 drm/i915: Move HAS_STRUCT_PAGE to obj->flags -:110: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #110: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.c:63: + struct lock_class_key *key, unsigned flags) -:133: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #133: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.h:53: + unsigned alloc_flags); total: 0 errors, 2 warnings, 0 checks, 350 lines checked f1417f7189ac drm/i915: Rework struct phys attachment handling c5121d3bf030 drm/i915: Convert i915_gem_object_attach_phys() to ww locking, v2. cd80a5137639 drm/i915: make lockdep slightly happier about execbuf. 81d63e3444e2 drm/i915: Disable userptr pread/pwrite support. e170f0547221 drm/i915: No longer allow exporting userptr through dma-buf 13f46a38f0eb drm/i915: Reject more ioctls for userptr, v2. 76fa2e87da9c drm/i915: Reject UNSYNCHRONIZED for userptr, v2. efd70139bae3 drm/i915: Make compilation of userptr code depend on MMU_NOTIFIER. 1f380a5600a4 drm/i915: Fix userptr so we do not have to worry about obj->mm.lock, v7. -:332: WARNING:LONG_LINE: line length of 121 exceeds 100 columns #332: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.h:605: +static inline int i915_gem_object_userptr_submit_init(struct drm_i915_gem_object *obj) { GEM_BUG_ON(1); return -ENODEV; } -:333: WARNING:LONG_LINE: line length of 121 exceeds 100 columns #333: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.h:606: +static inline int i915_gem_object_userptr_submit_done(struct drm_i915_gem_object *obj) { GEM_BUG_ON(1); return -ENODEV; } -:334: WARNING:LONG_LINE: line length of 106 exceeds 100 columns #334: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.h:607: +static inline void i915_gem_object_userptr_submit_fini(struct drm_i915_gem_object *obj) { GEM_BUG_ON(1); } -:335: WARNING:LONG_LINE: line length of 118 exceeds 100 columns #335: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.h:608: +static inline int i915_gem_object_userptr_validate(struct drm_i915_gem_object *obj) { GEM_BUG_ON(1); return -ENODEV; } -:394: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #394: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:2: * SPDX-License-Identifier: MIT -:398: WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line #398: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:6: + * + * Based on amdgpu_mn, which bears the following notice: -:399: WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line #399: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:7: + * Based on amdgpu_mn, which bears the following notice: + * -:484: WARNING:LONG_LINE: line length of 106 exceeds 100 columns #484: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:63: + struct drm_i915_gem_object *obj = container_of(mni, struct drm_i915_gem_object, userptr.notifier); -:1172: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided #1172: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:300: + pinned = ret = 0; -:1187: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1187: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:315: + if (mmu_interval_read_retry(&obj->userptr.notifier, + !obj->userptr.page_ref ? notifier_seq : -:1334: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment #1334: FILE: drivers/gpu/drm/i915/i915_drv.h:564: + spinlock_t notifier_lock; total: 0 errors, 8 warnings, 3 checks, 1267 lines checked fd4b18d157a8 drm/i915: Flatten obj->mm.lock 50d8873b420a drm/i915: Populate logical context during first pin. e5f8a7149fca drm/i915: Make ring submission compatible with obj->mm.lock removal, v2. ef351a4e9f96 drm/i915: Handle ww locking in init_status_page b1a804919d47 drm/i915: Rework clflush to work correctly without obj->mm.lock. 72088f888965 drm/i915: Pass ww ctx to intel_pin_to_display_plane baa8f9fbc98e drm/i915: Add object locking to vm_fault_cpu dedde1a8aad4 drm/i915: Move pinning to inside engine_wa_list_verify() -:72: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #72: FILE: drivers/gpu/drm/i915/gt/intel_workarounds.c:2215: + err = i915_vma_pin_ww(vma, &ww, 0, 0, + i915_vma_is_ggtt(vma) ? PIN_GLOBAL : PIN_USER); total: 0 errors, 0 warnings, 1 checks, 118 lines checked f7d9dda62c90 drm/i915: Take reservation lock around i915_vma_pin. d3246765f63f drm/i915: Make lrc_init_wa_ctx compatible with ww locking, v3. 173f4f1b1c63 drm/i915: Make __engine_unpark() compatible with ww locking. -:10: WARNING:REPEATED_WORD: Possible repeated word: 'many' #10: many many places where rpm is used, I chose the safest option total: 0 errors, 1 warnings, 0 checks, 16 lines checked 4c3c4d4088f1 drm/i915: Take obj lock around set_domain ioctl -:85: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #85: FILE: drivers/gpu/drm/i915/gem/i915_gem_domain.c:518: + err = i915_gem_object_wait(obj, + I915_WAIT_INTERRUPTIBLE | total: 0 errors, 0 warnings, 1 checks, 74 lines checked 8bc8d48fa1f5 drm/i915: Defer pin calls in buffer pool until first use by caller. bd2246c91faf drm/i915: Fix pread/pwrite to work with new locking rules. -:32: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #32: deleted file mode 100644 total: 0 errors, 1 warnings, 0 checks, 349 lines checked c721b167ca40 drm/i915: Fix workarounds selftest, part 1 327f719d9bcd drm/i915: Prepare for obj->mm.lock removal, v2. -:135: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: "Thomas Hellström" <thomas.hellstrom@xxxxxxxxx>' != 'Signed-off-by: Thomas Hellström <thomas.hellstrom@xxxxxxxxxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 96 lines checked aee3fe87816c drm/i915: Add igt_spinner_pin() to allow for ww locking around spinner. ef70b0b8e290 drm/i915: Add ww locking around vm_access() 6019d6c0eb3f drm/i915: Increase ww locking for perf. e03a1006484c drm/i915: Lock ww in ucode objects correctly a5ad0fac0fc8 drm/i915: Add ww locking to dma-buf ops, v2. afe92b46fb0e drm/i915: Add missing ww lock in intel_dsb_prepare. a953ed1b87c6 drm/i915: Fix ww locking in shmem_create_from_object 7990b3f44593 drm/i915: Use a single page table lock for each gtt. -:112: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return #112: FILE: drivers/gpu/drm/i915/gt/intel_gtt.c:85: + return i915_gem_object_lock(vm->scratch[0], ww); + } else { total: 0 errors, 1 warnings, 0 checks, 154 lines checked d02a3c08b6c8 drm/i915/selftests: Prepare huge_pages testcases for obj->mm.lock removal. fc461b458635 drm/i915/selftests: Prepare client blit for obj->mm.lock removal. be577dd52aef drm/i915/selftests: Prepare coherency tests for obj->mm.lock removal. 7d53063f4923 drm/i915/selftests: Prepare context tests for obj->mm.lock removal. ba8a88aed80f drm/i915/selftests: Prepare dma-buf tests for obj->mm.lock removal. 112ffa7bb2d9 drm/i915/selftests: Prepare execbuf tests for obj->mm.lock removal. 554806522541 drm/i915/selftests: Prepare mman testcases for obj->mm.lock removal. ccf4fc27e7ac drm/i915/selftests: Prepare object tests for obj->mm.lock removal. 56166af1f1c8 drm/i915/selftests: Prepare object blit tests for obj->mm.lock removal. a25c41efc1e7 drm/i915/selftests: Prepare igt_gem_utils for obj->mm.lock removal adfc47aa25f8 drm/i915/selftests: Prepare context selftest for obj->mm.lock removal b30d31903984 drm/i915/selftests: Prepare hangcheck for obj->mm.lock removal e85b79c98be5 drm/i915/selftests: Prepare execlists and lrc selftests for obj->mm.lock removal -:163: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #163: FILE: drivers/gpu/drm/i915/gt/selftest_lrc.c:1303: + lrc = i915_gem_object_pin_map_unlocked(ce->state->obj, i915_coherent_map_type(engine->i915)); total: 0 errors, 0 warnings, 1 checks, 130 lines checked 1412f472559a drm/i915/selftests: Prepare mocs tests for obj->mm.lock removal 538601003e61 drm/i915/selftests: Prepare ring submission for obj->mm.lock removal 170ae0178b2b drm/i915/selftests: Prepare timeline tests for obj->mm.lock removal 7b48384cbdf2 drm/i915/selftests: Prepare i915_request tests for obj->mm.lock removal e2bb3c22cac0 drm/i915/selftests: Prepare memory region tests for obj->mm.lock removal bb69aac3ea77 drm/i915/selftests: Prepare cs engine tests for obj->mm.lock removal 89f6f29df407 drm/i915/selftests: Prepare gtt tests for obj->mm.lock removal 2e2e7b38f85a drm/i915: Finally remove obj->mm.lock. 9fc64b960321 drm/i915: Keep userpointer bindings if seqcount is unchanged, v2. 96d6bd170d7a drm/i915: Move gt_revoke() slightly 28e263d3572c drm/i915: Add missing -EDEADLK path in execbuffer ggtt pinning. 79181322b8c3 drm/i915: Fix pin_map in scheduler selftests -:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one total: 0 errors, 1 warnings, 0 checks, 8 lines checked fa9a3aa7cc32 drm/i915: Add ww parameter to get_pages() callback 009aea508019 drm/i915: Add ww context to prepare_(read/write) -:6: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #6: This will allow us to explicitly pass the ww to pin_pages, when it starts taking it. total: 0 errors, 1 warnings, 0 checks, 107 lines checked c961b851f0f4 drm/i915: Pass ww ctx to pin_map -:456: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided #456: FILE: drivers/gpu/drm/i915/i915_perf.c:1665: + batch = cs = i915_gem_object_pin_map(bo, &ww, I915_MAP_WB); total: 0 errors, 0 warnings, 1 checks, 337 lines checked e0b2dcbb577c drm/i915: Pass ww ctx to i915_gem_object_pin_pages -:80: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #80: FILE: drivers/gpu/drm/i915/gem/i915_gem_domain.c:464: + err = i915_gem_object_wait(obj, + I915_WAIT_INTERRUPTIBLE | total: 0 errors, 0 warnings, 1 checks, 332 lines checked 0872f4e47cc7 drm/i915: Remove asynchronous vma binding _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
