== Series Details == Series: Disassociate display version from INTEL_GEN() (rev4) URL : https://patchwork.freedesktop.org/series/88198/ State : warning == Summary == $ dim checkpatch origin/drm-tip c81a8f093d82 drm/i915/display: Convert gen5/gen6 tests to IS_IRONLAKE/IS_SANDYBRIDGE -:130: CHECK:CAMELCASE: Avoid CamelCase: <ILK_eDP_A_DISABLE> #130: FILE: drivers/gpu/drm/i915/display/intel_display.c:11604: + if (IS_IRONLAKE(dev_priv) && (intel_de_read(dev_priv, FUSE_STRAP) & ILK_eDP_A_DISABLE)) total: 0 errors, 0 warnings, 1 checks, 216 lines checked 6297fd1b97dd drm/i915: Add DISPLAY_VER() and related macros -:73: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #73: FILE: drivers/gpu/drm/i915/i915_drv.h:1245: +#define IS_DISPLAY_RANGE(i915, from, until) \ + (DISPLAY_VER(i915) >= (from) && DISPLAY_VER(i915) <= (until)) -:89: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects? #89: FILE: drivers/gpu/drm/i915/i915_pci.c:39: +#define GEN(x) .gen = (x), .gen_mask = BIT((x) - 1), .display.version = (x) total: 0 errors, 0 warnings, 2 checks, 27 lines checked 188b76a17daf drm/i915/display: Eliminate most usage of INTEL_GEN() -:2043: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'port == PORT_E' #2043: FILE: drivers/gpu/drm/i915/display/intel_display.c:6717: + if (DISPLAY_VER(dev_priv) < 9 && (port == PORT_E) && intel_de_read(dev_priv, LPT_TRANSCONF) & TRANS_ENABLE) { -:2631: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 63) #2631: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:153: + if (DISPLAY_VER(dev_priv) >= 9) /* no global SR status; inspect per-plane WM */; -:4188: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'intel_dp->psr_dpcd[0] == DP_PSR2_WITH_Y_COORD_IS_SUPPORTED' #4188: FILE: drivers/gpu/drm/i915/display/intel_psr.c:324: + if (DISPLAY_VER(dev_priv) >= 9 && (intel_dp->psr_dpcd[0] == DP_PSR2_WITH_Y_COORD_IS_SUPPORTED)) { total: 0 errors, 1 warnings, 2 checks, 4216 lines checked 915c0e51a3f4 drm/i915: Convert INTEL_GEN() to DISPLAY_VER() as appropriate in intel_pm.c d729e75a5f02 drm/i915: Convert INTEL_GEN() to DISPLAY_VER() as appropriate in i915_irq.c fa2c5874debd drm/i915/display: Simplify GLK display version tests -:77: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #77: - (IS_DISPLAY_RANGE(dev_priv, 11, E) || IS_DISPLAY_VER(dev_priv, 10)) -:388: WARNING:LONG_LINE: line length of 235 exceeds 100 columns #388: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:2419: + if ((DISPLAY_VER(dev_priv) >= 11 || IS_CANNONLAKE(dev_priv)) && ((connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort && !to_intel_connector(connector)->mst_port) || connector->connector_type == DRM_MODE_CONNECTOR_eDP)) -:574: WARNING:LONG_LINE: line length of 195 exceeds 100 columns #574: FILE: drivers/gpu/drm/i915/display/intel_vdsc.c:349: + if ((DISPLAY_VER(i915) >= 11 || IS_CANNONLAKE(i915)) && (pipe != PIPE_A || (cpu_transcoder == TRANSCODER_EDP || cpu_transcoder == TRANSCODER_DSI_0 || cpu_transcoder == TRANSCODER_DSI_1))) -:741: WARNING:LONG_LINE: line length of 104 exceeds 100 columns #741: FILE: drivers/gpu/drm/i915/display/skl_universal_plane.c:2230: + if ((DISPLAY_VER(dev_priv) >= 11 || IS_CANNONLAKE(dev_priv)) && val & PLANE_CTL_FLIP_HORIZONTAL) total: 0 errors, 4 warnings, 0 checks, 574 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
