On Wed, Mar 27, 2013 at 5:49 PM, Jesse Barnes <jbarnes at virtuousgeek.org> wrote: > Changelog and summary could be better and mention the new > compute_config function and how it replaces the mode_fixup one. > > Also, TIMINGS_SET probably wasn't a very good name in the first place, > since it really deals with letter/pillar box configs. But that's not > really a problem with your patch and could be changed in a follow-on. > > Reviewed-by: Jesse Barnes <jbarnes at virtuousgeek.org> I've forgotten to add a commit addition discussed with Ville: "Note that since the lvds code unconditionally sets the crtc timings, we can also unconditionally set the respective flag and not just when we set special timings like the old code did." I'll smash another paragraph for you on top (which also address an issue raised by Paulo): "This requires that we pass the pipe config around to encoders, so that they can set special attributes and set constraints. To do so introduce a new ->compute_config encoder callback, which is called in stead of the drm crtc helper's ->mode_fixup. "To avoid massive churn all over the codebase we don't want to convert all existing ->mode_fixup functions. Instead I've opted to convert them on an as-needed basis (mostly to cut down on rebase conflicts and to have more freedom to experiment around while developing the patches)." Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
