On Wed, 27 Mar 2013 00:44:52 +0100
Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> + bool (*compute_config)(struct intel_encoder *,
> + struct intel_crtc_config *);
> void (*pre_pll_enable)(struct intel_encoder *);
> void (*pre_enable)(struct intel_encoder *);
> void (*enable)(struct intel_encoder *);
> @@ -203,6 +201,10 @@ struct intel_connector {
> struct intel_crtc_config {
> struct drm_display_mode requested_mode;
> struct drm_display_mode adjusted_mode;
> + /* This flag must be set by the encoder's compute_config callback if it
> + * changes the crtc timings in the mode to prevent the crtc fixup from
> + * overwriting them. Currently only lvds needs that. */
> + bool timings_set;
The compute_config function could actually use some kdoc instead of
putting it over the timings_set function. It'll need to be expanded to
cover all the pipe_config bits eventually, what they mean and when they
should be set.
--
Jesse Barnes, Intel Open Source Technology Center
