Quoting Daniele Ceraolo Spurio (2021-03-01 19:31:51) > +static inline bool intel_pxp_is_active(const struct intel_pxp *pxp) > +{ > + return pxp->arb_is_in_play; > +} > +static bool intel_pxp_session_is_in_play(struct intel_pxp *pxp, u32 id) > +{ > + struct intel_gt *gt = pxp_to_gt(pxp); > + intel_wakeref_t wakeref; > + u32 sip = 0; > + > + with_intel_runtime_pm(gt->uncore->rpm, wakeref) > + sip = intel_uncore_read(gt->uncore, GEN12_KCR_SIP); > + > + return sip & BIT(id); > +} > + > +bool intel_pxp_arb_session_is_in_play(struct intel_pxp *pxp) > +{ > + return intel_pxp_session_is_in_play(pxp, ARB_SESSION); > +} So pxp->arb_is_in_play is not the same as intel_pxp_arb_session_is_in_play(). That's confusing. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx