On Wed, Feb 17, 2021 at 08:58:12PM +0000, Winkler, Tomas wrote:
On Tue, 16 Feb 2021, Tomas Winkler <tomas.winkler@xxxxxxxxx> wrote:
> Add the platform driver for i915 on-die spi device, exposed via mfd
> framework.
>
> Cc: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>
> Cc: Lucas De Marchi <lucas.demarchi@xxxxxxxxx>
> Signed-off-by: Tomas Winkler <tomas.winkler@xxxxxxxxx>
> ---
> drivers/gpu/drm/i915/Kconfig | 2 +
> drivers/gpu/drm/i915/Makefile | 3 +
> drivers/gpu/drm/i915/spi/intel_spi_drv.c | 116
> +++++++++++++++++++++++
> 3 files changed, 121 insertions(+)
> create mode 100644 drivers/gpu/drm/i915/spi/intel_spi_drv.c
>
> diff --git a/drivers/gpu/drm/i915/Kconfig
> b/drivers/gpu/drm/i915/Kconfig index abcaa8da45ac..13c870e5878e 100644
> --- a/drivers/gpu/drm/i915/Kconfig
> +++ b/drivers/gpu/drm/i915/Kconfig
> @@ -27,6 +27,8 @@ config DRM_I915
> select CEC_CORE if CEC_NOTIFIER
> select VMAP_PFN
> select MFD_CORE
> + select MTD
Selecting MTD does not seem to be a popular thing to do, which is usually a
clue it's probably the wrong thing to do.
Depends, if it is not selected you'll end with wrongly configured system.
no. I believe the idea is that having a CONFIG_I915_SPI, you could do
depends on MTD
like the other drivers doing similar thing:
git grep MTD -- ':(exclude)drivers/mtd' ':(exclude)arch/' '*Kconfig'
Lucas De Marchi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
