On Fri, Jan 29, 2021 at 02:01:32PM +0200, Jani Nikula wrote:
On Fri, 29 Jan 2021, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote:
Quoting Jani Nikula (2021-01-29 11:12:02)
On Thu, 28 Jan 2021, Matt Roper <matthew.d.roper@xxxxxxxxx> wrote:
> From: Vandita Kulkarni <vandita.kulkarni@xxxxxxxxx>
>
> Add the qp table for 444 formats, for 8bpc, 10bpc and 12bpc, as given by
> the VESA C model for DSC 1.1
>
> Cc: Manasi Navare <manasi.d.navare@xxxxxxxxx>
> Signed-off-by: Vandita Kulkarni <vandita.kulkarni@xxxxxxxxx>
> Signed-off-by: Matt Roper <matthew.d.roper@xxxxxxxxx>
> ---
> .../gpu/drm/i915/display/intel_qp_tables.h | 294 ++++++++++++++++++
> drivers/gpu/drm/i915/display/intel_vdsc.c | 22 +-
> 2 files changed, 315 insertions(+), 1 deletion(-)
> create mode 100644 drivers/gpu/drm/i915/display/intel_qp_tables.h
>
> diff --git a/drivers/gpu/drm/i915/display/intel_qp_tables.h b/drivers/gpu/drm/i915/display/intel_qp_tables.h
> new file mode 100644
> index 000000000000..13694d5220d4
> --- /dev/null
> +++ b/drivers/gpu/drm/i915/display/intel_qp_tables.h
> @@ -0,0 +1,294 @@
> +/* SPDX-License-Identifier: MIT */
> +/*
> + * Copyright © 2019 Intel Corporation
> + */
> +
The include guard is missing.
Should we even be putting large tables into a header?
Would this be better as a .c?
Agreed.
ugh... that huge table on a header and even marked as __maybe_unused is
very ugly. We should really not do that.
Lucas De Marchi
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
