On Thu, Feb 04, 2021 at 09:43:26PM +0200, Jani Nikula wrote: > static void skl_pfit_enable(const struct intel_crtc_state *crtc_state) > { > struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc); Missed all the skl_pfit*(). > diff --git a/drivers/gpu/drm/i915/display/intel_sprite.c b/drivers/gpu/drm/i915/display/intel_sprite.c > index 46fcb5b9983f..4cbdb8fd4bb1 100644 > --- a/drivers/gpu/drm/i915/display/intel_sprite.c > +++ b/drivers/gpu/drm/i915/display/intel_sprite.c > @@ -138,68 +138,6 @@ int intel_plane_check_src_coordinates(struct intel_plane_state *plane_state) > return 0; > } > > -void > -skl_program_scaler(struct intel_plane *plane, > - const struct intel_crtc_state *crtc_state, > - const struct intel_plane_state *plane_state) If we move this we should rename it to skl_program_plane_scaler() or something along those lines. Ideally I'd like to have a single function that works for both pipe and plane scaling but that might require some actual thought so not going to be a trivial rename/move. -- Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx