From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> A revised version of the DDI clock routing refactoring. Dropped the icl_dpclka_cfgcr0_reg() & co. extraction as Lucas suggested since they got removed at the end anyway. Was a bit worried it might make things more confusing due to icl_dpclka_cfgcr0_clk_off() already being there, but looks OK in the end anyway I think. Also did a bunch if s/dev_priv/i915/ based on Lucas's review. Didn't feel comfortable sneaking all of it into the other patches since it would have lowered the SNR. Hence the new patch at the end to clean up the stragglers. Ville Syrjälä (14): drm/i915: Introduce .{enable,disable}_clock() encoder vfuncs drm/i915: Extract hsw_ddi_{enable,disable}_clock() drm/i915: Extract skl_ddi_{enable,disable}_clock() drm/i195: Extract cnl_ddi_{enable,disable}_clock() drm/i915: Convert DG1 over to .{enable,disable}_clock() drm/i915: Extract icl+ .{enable,disable}_clock() vfuncs drm/i915: Use intel_de_rmw() for DDI clock routing drm/i915: Sprinkle a few missing locks around shared DDI clock registers drm/i915: Sprinkle WARN(!pll) into icl/dg1 .clock_enable() drm/i915: Extract _cnl_ddi_{enable,disable}_clock() drm/i915: Split adl-s/rkl from icl_ddi_combo_{enable,disable}_clock() drm/i915: Use .disable_clock() for pll sanitation drm/i915: Relocate icl_sanitize_encoder_pll_mapping() drm/i915: s/dev_priv/i915/ for the remainder of DDI clock routing drivers/gpu/drm/i915/display/icl_dsi.c | 1 + drivers/gpu/drm/i915/display/intel_ddi.c | 576 ++++++++++-------- .../drm/i915/display/intel_display_types.h | 6 + 3 files changed, 315 insertions(+), 268 deletions(-) -- 2.26.2 _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx