Quoting Tvrtko Ursulin (2021-02-02 12:03:02) > > diff --git a/drivers/gpu/drm/i915/gt/selftest_execlists.c b/drivers/gpu/drm/i915/gt/selftest_execlists.c > > index 5d7fac383add..9304a35384aa 100644 > > --- a/drivers/gpu/drm/i915/gt/selftest_execlists.c > > +++ b/drivers/gpu/drm/i915/gt/selftest_execlists.c > > @@ -4715,7 +4715,7 @@ int intel_execlists_live_selftests(struct drm_i915_private *i915) > > SUBTEST(live_virtual_reset), > > }; > > > > - if (!HAS_EXECLISTS(i915)) > > + if (i915->gt.submission_method != INTEL_SUBMISSION_ELSP) > > return 0; > > > > if (intel_gt_is_wedged(&i915->gt)) > > diff --git a/drivers/gpu/drm/i915/gt/selftest_ring_submission.c b/drivers/gpu/drm/i915/gt/selftest_ring_submission.c > > index 3350e7c995bc..6cd9f6bc240c 100644 > > --- a/drivers/gpu/drm/i915/gt/selftest_ring_submission.c > > +++ b/drivers/gpu/drm/i915/gt/selftest_ring_submission.c > > @@ -291,7 +291,7 @@ int intel_ring_submission_live_selftests(struct drm_i915_private *i915) > > SUBTEST(live_ctx_switch_wa), > > }; > > > > - if (HAS_EXECLISTS(i915)) > > + if (i915->gt.submission_method > INTEL_SUBMISSION_RING) > > Not sure the above two hunks in selftests are an improvement, not seeing > how using enum ordering is better than a feature check. Wait 40 patches. > Mechanics looks fine. I'd prefer the selftests to remain as is but not > mandatory. The execlists tests are not suitable as-is for the guc. And they are in the habit of breaking the test to hide impedance mismatches with the guc. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
