On Tue, Feb 26, 2013 at 05:57:20PM -0300, Paulo Zanoni wrote: > Hi > > 2013/2/25 Rodrigo Vivi <rodrigo.vivi at gmail.com>: > > According to HSW PM programming guide, frequency bits starts at > > 24 instead of 25 > > This looks incomplete. Please check all the cases where RPNSWREQ is > used, I think we need to fix them too. Also, according to the PM > programming guide, all the other RPNSWREQ bits are reserved/read-only, > but I still see our code trying to set some of these bits (even if > it's trying to set it to zero), so I guess that on Haswell all the > writes to RPNSWREQ should only contain the HSW_FREQUENCY macro, not > others. And for those other bits, we need to discover where did they > go. We really should get this, or some version of this patch committed sooner rather than later. If there is disagreement over the entire series, could you please extract the important part into an individual patch? [snip] -- Ben Widawsky, Intel Open Source Technology Center
