== Series Details == Series: series starting with [v14,1/2] drm/i915/display: Support PSR Multiple Instances URL : https://patchwork.freedesktop.org/series/86433/ State : warning == Summary == $ dim checkpatch origin/drm-tip 2beed3acee30 drm/i915/display: Support PSR Multiple Instances -:88: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #88: FILE: drivers/gpu/drm/i915/display/intel_display.h:420: +#define for_each_intel_encoder_mask_can_psr(dev, intel_encoder, encoder_mask) \ + list_for_each_entry((intel_encoder), &(dev)->mode_config.encoder_list, base.head) \ + for_each_if(((encoder_mask) & drm_encoder_mask(&(intel_encoder)->base)) && \ + intel_encoder_can_psr(intel_encoder)) -:88: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'intel_encoder' - possible side-effects? #88: FILE: drivers/gpu/drm/i915/display/intel_display.h:420: +#define for_each_intel_encoder_mask_can_psr(dev, intel_encoder, encoder_mask) \ + list_for_each_entry((intel_encoder), &(dev)->mode_config.encoder_list, base.head) \ + for_each_if(((encoder_mask) & drm_encoder_mask(&(intel_encoder)->base)) && \ + intel_encoder_can_psr(intel_encoder)) -:97: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #97: FILE: drivers/gpu/drm/i915/display/intel_display.h:429: +#define for_each_intel_encoder_can_psr(dev, intel_encoder) \ + for_each_intel_encoder((dev), (intel_encoder)) \ + for_each_if(intel_encoder_can_psr(intel_encoder)) -:97: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'intel_encoder' - possible side-effects? #97: FILE: drivers/gpu/drm/i915/display/intel_display.h:429: +#define for_each_intel_encoder_can_psr(dev, intel_encoder) \ + for_each_intel_encoder((dev), (intel_encoder)) \ + for_each_if(intel_encoder_can_psr(intel_encoder)) -:375: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'intel_dp' - possible side-effects? #375: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:1795: +#define CAN_PSR(intel_dp) (HAS_PSR(dp_to_i915(intel_dp)) && \ + (intel_dp)->psr.sink_support && \ + (intel_dp)->psr.source_support) -:1188: CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #1188: FILE: drivers/gpu/drm/i915/display/intel_psr.c:1230: + crtc_state->uapi.encoder_mask) { + -:1320: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1320: FILE: drivers/gpu/drm/i915/display/intel_psr.c:1523: + if (!intel_dp->psr.enabled || + (intel_dp->psr.enabled && intel_dp->psr.psr2_enabled)) { total: 2 errors, 0 warnings, 5 checks, 1731 lines checked 84aa39bab08a drm/i915/display: Support Multiple Transcoders' PSR status on debugfs _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx