Re: [RFC-v23 00/13] Introduce Intel PXP component - Mesa single session

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



+Krishnaish

Actually, Rodrigo requested GET_PARAM for this API(due to IGT tests) so I believe GET_PARAM is getting implemented. Krishnaiah? 

-----Original Message-----
From: Lionel Landwerlin <lionel.g.landwerlin@xxxxxxxxx> 
Sent: Monday, January 25, 2021 7:38 AM
To: Gaurav, Kumar <kumar.gaurav@xxxxxxxxx>; Huang, Sean Z <sean.z.huang@xxxxxxxxx>; Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
Cc: Lahtinen, Joonas <joonas.lahtinen@xxxxxxxxx>; Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>; Ekstrand, Jason <jason.ekstrand@xxxxxxxxx>
Subject: Re:  [RFC-v23 00/13] Introduce Intel PXP component - Mesa single session

Okay, if the get_param is too much at the point, can we at least have a define to reflect that this is a special number from the kernel?

Thanks,

-Lionel

On 23/01/2021 23:47, Gaurav, Kumar wrote:
> Yes, this should not be problem since MESA is already using MI_SET_APPID with app_id 0xf.
>
> I proposed this earlier but I was told that MESA team will not be comfortable in querying app_id or session_states.
> Although check for proper session_state should be part of context robustness check.
>
> -----Original Message-----
> From: Lionel Landwerlin <lionel.g.landwerlin@xxxxxxxxx>
> Sent: Saturday, January 23, 2021 6:19 AM
> To: Huang, Sean Z <sean.z.huang@xxxxxxxxx>; 
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> Cc: Gaurav, Kumar <kumar.gaurav@xxxxxxxxx>; Lahtinen, Joonas 
> <joonas.lahtinen@xxxxxxxxx>; Joonas Lahtinen 
> <joonas.lahtinen@xxxxxxxxxxxxxxx>; Ekstrand, Jason 
> <jason.ekstrand@xxxxxxxxx>
> Subject: Re:  [RFC-v23 00/13] Introduce Intel PXP component 
> - Mesa single session
>
> Hi,
>
> One of the thing that came up during UMD review is that the default session ID is actually uAPI :
> https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8064#note_77
> 6201 Could we expose it through a get_param on the context?
>
> Thanks,
>
> -Lionel
>
> On 19/01/2021 09:43, Huang, Sean Z wrote:
>> PXP (Protected Xe Path) is an i915 component, available on
>> GEN12+ that helps to establish the hardware protected session
>> and manage the status of the alive software session, as well as its 
>> life cycle.
>>
>> This patch series is to allow the kernel space to create and manage a 
>> single hardware session (a.k.a. default session or arbitrary session).
>> So user can allocate the protected buffer, which is encrypted with 
>> the leverage of the arbitrary hardware session.
>>
>>
>> rev23:
>>       #09, #12
>>       - Require user space to explicitly set recoverable flag to
>>         false for protected context creation.
>>
>>       #13
>>       - Add Cc of reviewers in commit message.
>>
>>
>> Anshuman Gupta (1):
>>     drm/i915/pxp: Add plane decryption support
>>
>> Bommu Krishnaiah (2):
>>     drm/i915/uapi: introduce drm_i915_gem_create_ext
>>     drm/i915/pxp: User interface for Protected buffer
>>
>> Huang, Sean Z (9):
>>     drm/i915/pxp: Introduce Intel PXP component
>>     drm/i915/pxp: set KCR reg init during the boot time
>>     drm/i915/pxp: Implement funcs to create the TEE channel
>>     drm/i915/pxp: Create the arbitrary session after boot
>>     drm/i915/pxp: Func to send hardware session termination
>>     drm/i915/pxp: Enable PXP irq worker and callback stub
>>     drm/i915/pxp: Destroy arb session upon teardown
>>     drm/i915/pxp: Enable PXP power management
>>     drm/i915/pxp: Expose session state for display protection flip
>>
>> Vitaly Lubart (1):
>>     mei: pxp: export pavp client to me client bus
>>
>>    drivers/gpu/drm/i915/Kconfig                  |  21 ++
>>    drivers/gpu/drm/i915/Makefile                 |   9 +
>>    drivers/gpu/drm/i915/display/intel_sprite.c   |  21 +-
>>    drivers/gpu/drm/i915/gem/i915_gem_context.c   |  13 +
>>    drivers/gpu/drm/i915/gem/i915_gem_context.h   |   5 +
>>    .../gpu/drm/i915/gem/i915_gem_context_types.h |   2 +
>>    drivers/gpu/drm/i915/gem/i915_gem_create.c    |  68 +++++-
>>    .../gpu/drm/i915/gem/i915_gem_object_types.h  |   5 +
>>    drivers/gpu/drm/i915/gt/intel_gt.c            |   5 +
>>    drivers/gpu/drm/i915/gt/intel_gt_irq.c        |  14 ++
>>    drivers/gpu/drm/i915/gt/intel_gt_pm.c         |   4 +
>>    drivers/gpu/drm/i915/gt/intel_gt_types.h      |   3 +
>>    drivers/gpu/drm/i915/i915_drv.c               |   7 +-
>>    drivers/gpu/drm/i915/i915_drv.h               |   6 +
>>    drivers/gpu/drm/i915/i915_reg.h               |   2 +
>>    drivers/gpu/drm/i915/pxp/intel_pxp.c          | 193 +++++++++++++++
>>    drivers/gpu/drm/i915/pxp/intel_pxp.h          |  70 ++++++
>>    drivers/gpu/drm/i915/pxp/intel_pxp_arb.c      | 208 ++++++++++++++++
>>    drivers/gpu/drm/i915/pxp/intel_pxp_arb.h      |  17 ++
>>    drivers/gpu/drm/i915/pxp/intel_pxp_cmd.c      | 223 +++++++++++++++++
>>    drivers/gpu/drm/i915/pxp/intel_pxp_cmd.h      |  19 ++
>>    drivers/gpu/drm/i915/pxp/intel_pxp_context.c  |  28 +++
>>    drivers/gpu/drm/i915/pxp/intel_pxp_context.h  |  15 ++
>>    drivers/gpu/drm/i915/pxp/intel_pxp_pm.c       |  65 +++++
>>    drivers/gpu/drm/i915/pxp/intel_pxp_pm.h       |  31 +++
>>    drivers/gpu/drm/i915/pxp/intel_pxp_tee.c      | 202 +++++++++++++++
>>    drivers/gpu/drm/i915/pxp/intel_pxp_tee.h      |  17 ++
>>    drivers/gpu/drm/i915/pxp/intel_pxp_types.h    |  38 +++
>>    drivers/misc/mei/Kconfig                      |   2 +
>>    drivers/misc/mei/Makefile                     |   1 +
>>    drivers/misc/mei/pxp/Kconfig                  |  13 +
>>    drivers/misc/mei/pxp/Makefile                 |   7 +
>>    drivers/misc/mei/pxp/mei_pxp.c                | 230 ++++++++++++++++++
>>    drivers/misc/mei/pxp/mei_pxp.h                |  18 ++
>>    include/drm/i915_component.h                  |   1 +
>>    include/drm/i915_pxp_tee_interface.h          |  45 ++++
>>    include/uapi/drm/i915_drm.h                   |  66 +++++
>>    37 files changed, 1686 insertions(+), 8 deletions(-)
>>    create mode 100644 drivers/gpu/drm/i915/pxp/intel_pxp.c
>>    create mode 100644 drivers/gpu/drm/i915/pxp/intel_pxp.h
>>    create mode 100644 drivers/gpu/drm/i915/pxp/intel_pxp_arb.c
>>    create mode 100644 drivers/gpu/drm/i915/pxp/intel_pxp_arb.h
>>    create mode 100644 drivers/gpu/drm/i915/pxp/intel_pxp_cmd.c
>>    create mode 100644 drivers/gpu/drm/i915/pxp/intel_pxp_cmd.h
>>    create mode 100644 drivers/gpu/drm/i915/pxp/intel_pxp_context.c
>>    create mode 100644 drivers/gpu/drm/i915/pxp/intel_pxp_context.h
>>    create mode 100644 drivers/gpu/drm/i915/pxp/intel_pxp_pm.c
>>    create mode 100644 drivers/gpu/drm/i915/pxp/intel_pxp_pm.h
>>    create mode 100644 drivers/gpu/drm/i915/pxp/intel_pxp_tee.c
>>    create mode 100644 drivers/gpu/drm/i915/pxp/intel_pxp_tee.h
>>    create mode 100644 drivers/gpu/drm/i915/pxp/intel_pxp_types.h
>>    create mode 100644 drivers/misc/mei/pxp/Kconfig
>>    create mode 100644 drivers/misc/mei/pxp/Makefile
>>    create mode 100644 drivers/misc/mei/pxp/mei_pxp.c
>>    create mode 100644 drivers/misc/mei/pxp/mei_pxp.h
>>    create mode 100644 include/drm/i915_pxp_tee_interface.h
>>

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx



[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux