Re: [PATCH] drm/i915: Add DEBUG_GEM to the recommended CI config

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 14 Jan 2021, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote:
> Now that i915 compiles cleanly with Werror, we can enforce enabling
> DEBUG_GEM when selecting the default debug config.
>
> Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> Cc: Jani Nikula <jani.nikula@xxxxxxxxx>
> ---
>  drivers/gpu/drm/i915/Kconfig.debug | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/Kconfig.debug b/drivers/gpu/drm/i915/Kconfig.debug
> index 0fb7fd0ef717..3701bae5b855 100644
> --- a/drivers/gpu/drm/i915/Kconfig.debug
> +++ b/drivers/gpu/drm/i915/Kconfig.debug
> @@ -39,10 +39,12 @@ config DRM_I915_DEBUG
>  	select DRM_DEBUG_SELFTEST
>  	select DMABUF_SELFTESTS
>  	select SW_SYNC # signaling validation framework (igt/syncobj*)
> +	select DRM_I915_WERROR

I think this line should be removed to fix [1]. Keep DRM_I915_WERROR
orthogonal.

BR,
Jani.


[1] http://lore.kernel.org/r/20210122115918.63b56fa1@xxxxxxxxxxxxxxxx


> +	select DRM_I915_DEBUG_GEM
> +	select DRM_I915_DEBUG_MMIO
> +	select DRM_I915_DEBUG_RUNTIME_PM
>  	select DRM_I915_SW_FENCE_DEBUG_OBJECTS
>  	select DRM_I915_SELFTEST
> -	select DRM_I915_DEBUG_RUNTIME_PM
> -	select DRM_I915_DEBUG_MMIO
>  	select BROKEN # for prototype uAPI
>  	default n
>  	help

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx



[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux