Quoting Andi Shyti (2021-01-21 15:49:49)
> Hi Chris,
>
> On Wed, Jan 20, 2021 at 12:22:00PM +0000, Chris Wilson wrote:
> > Looking to the future, we want to set the scheduling attributes
> > explicitly and so replace the generic engine->schedule() with the more
> > direct i915_request_set_priority()
> >
> > What it loses in removing the 'schedule' name from the function, it
> > gains in having an explicit entry point with a stated goal.
> >
> > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> > ---
> > drivers/gpu/drm/i915/display/intel_display.c | 5 ++-
> > drivers/gpu/drm/i915/gem/i915_gem_object.h | 5 ++-
> > drivers/gpu/drm/i915/gem/i915_gem_wait.c | 29 +++++-----------
> > drivers/gpu/drm/i915/gt/intel_engine_cs.c | 3 --
> > .../gpu/drm/i915/gt/intel_engine_heartbeat.c | 4 +--
> > drivers/gpu/drm/i915/gt/intel_engine_types.h | 29 ++++++++--------
> > drivers/gpu/drm/i915/gt/intel_engine_user.c | 2 +-
> > .../drm/i915/gt/intel_execlists_submission.c | 3 +-
> > drivers/gpu/drm/i915/gt/selftest_execlists.c | 33 +++++--------------
> > drivers/gpu/drm/i915/gt/selftest_hangcheck.c | 11 +++----
> > .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 1 -
> > drivers/gpu/drm/i915/i915_request.c | 10 +++---
> > drivers/gpu/drm/i915/i915_scheduler.c | 15 +++++----
> > drivers/gpu/drm/i915/i915_scheduler.h | 3 +-
> > 14 files changed, 59 insertions(+), 94 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> > index 6f04f85812fe..265344d98cbb 100644
> > --- a/drivers/gpu/drm/i915/display/intel_display.c
> > +++ b/drivers/gpu/drm/i915/display/intel_display.c
> > @@ -13543,7 +13543,6 @@ int
> > intel_prepare_plane_fb(struct drm_plane *_plane,
> > struct drm_plane_state *_new_plane_state)
> > {
> > - struct i915_sched_attr attr = { .priority = I915_PRIORITY_DISPLAY };
>
> do we still need the 'i915_scheduler_types' type?
Not for the foreseeable future.
It's been a long time since I put frequency in the scheduling attr, and
if asked to revive it today, I would make it a specific
i915_request_set_frequency.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
