> -----Original Message----- > From: Jani Nikula <jani.nikula@xxxxxxxxx> > Sent: Thursday, January 14, 2021 2:16 PM > To: Gupta, Anshuman <anshuman.gupta@xxxxxxxxx> > Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx; ville.syrjala@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v2 14/17] drm/i915/pps: refactor init abstractions > > On Wed, 13 Jan 2021, Anshuman Gupta <anshuman.gupta@xxxxxxxxx> > wrote: > > On 2021-01-08 at 19:44:22 +0200, Jani Nikula wrote: > >> @@ -1366,20 +1352,21 @@ void intel_pps_encoder_reset(struct > intel_dp *intel_dp) > >> * Reinit the power sequencer, in case BIOS did something > nasty > > IMHO above comment would need a improvement, or nuke > it ? > > as intel_pps_encoder_reset() will also get called from > intel_pps_init() > > unlike only while resuming from suspend. > > How about this? > > - * Reinit the power sequencer, in case BIOS did something nasty > - * with it. > + * Reinit the power sequencer also on the resume path, in case > + * BIOS did something nasty with it. > With that comment change. Reviewed-by: Anshuman Gupta <anshuman.gupta@xxxxxxxxx> > > BR, > Jani. > > > -- > Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
