== Series Details == Series: Use TGL stepping info and add ADLS platform changes URL : https://patchwork.freedesktop.org/series/85639/ State : warning == Summary == $ dim checkpatch origin/drm-tip 8370ee3ba04f drm/i915/tgl: Use TGL stepping info for applying WAs -:198: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'p' - possible side-effects? #198: FILE: drivers/gpu/drm/i915/i915_drv.h:1595: +#define IS_TGL_DISP_STEPPING(p, since, until) \ (IS_TIGERLAKE(p) && \ + tgl_stepping_get(p)->disp_stepping >= (since) && \ + tgl_stepping_get(p)->disp_stepping <= (until)) -:206: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'p' - possible side-effects? #206: FILE: drivers/gpu/drm/i915/i915_drv.h:1600: +#define IS_TGL_UY_GT_STEPPING(p, since, until) \ ((IS_TGL_U(p) || IS_TGL_Y(p)) && \ + tgl_stepping_get(p)->gt_stepping >= (since) && \ + tgl_stepping_get(p)->gt_stepping <= (until)) -:214: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'p' - possible side-effects? #214: FILE: drivers/gpu/drm/i915/i915_drv.h:1605: +#define IS_TGL_GT_STEPPING(p, since, until) \ (IS_TIGERLAKE(p) && \ !(IS_TGL_U(p) || IS_TGL_Y(p)) && \ + tgl_stepping_get(p)->gt_stepping >= (since) && \ + tgl_stepping_get(p)->gt_stepping <= (until)) total: 0 errors, 0 warnings, 3 checks, 182 lines checked 6e0b18efc188 drm/i915/adl_s: Add ADL-S platform info and PCI ids -:123: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'p' - possible side-effects? #123: FILE: drivers/gpu/drm/i915/i915_drv.h:1639: +#define IS_ADLS_DISP_STEPPING(p, since, until) \ + (IS_ALDERLAKE_S(p) && \ + tgl_stepping_get(p)->disp_stepping >= (since) && \ + tgl_stepping_get(p)->disp_stepping <= (until)) -:128: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'p' - possible side-effects? #128: FILE: drivers/gpu/drm/i915/i915_drv.h:1644: +#define IS_ADLS_GT_STEPPING(p, since, until) \ + (IS_ALDERLAKE_S(p) && \ + tgl_stepping_get(p)->gt_stepping >= (since) && \ + tgl_stepping_get(p)->gt_stepping <= (until)) -:200: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #200: FILE: include/drm/i915_pciids.h:638: +#define INTEL_ADLS_IDS(info) \ + INTEL_VGA_DEVICE(0x4680, info), \ + INTEL_VGA_DEVICE(0x4681, info), \ + INTEL_VGA_DEVICE(0x4682, info), \ + INTEL_VGA_DEVICE(0x4683, info), \ + INTEL_VGA_DEVICE(0x4690, info), \ + INTEL_VGA_DEVICE(0x4691, info), \ + INTEL_VGA_DEVICE(0x4692, info), \ + INTEL_VGA_DEVICE(0x4693, info) -:200: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'info' - possible side-effects? #200: FILE: include/drm/i915_pciids.h:638: +#define INTEL_ADLS_IDS(info) \ + INTEL_VGA_DEVICE(0x4680, info), \ + INTEL_VGA_DEVICE(0x4681, info), \ + INTEL_VGA_DEVICE(0x4682, info), \ + INTEL_VGA_DEVICE(0x4683, info), \ + INTEL_VGA_DEVICE(0x4690, info), \ + INTEL_VGA_DEVICE(0x4691, info), \ + INTEL_VGA_DEVICE(0x4692, info), \ + INTEL_VGA_DEVICE(0x4693, info) total: 1 errors, 0 warnings, 3 checks, 128 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx