Quoting Vivi, Rodrigo (2021-01-07 17:31:36) > On Wed, 2021-01-06 at 15:12 -0800, Huang, Sean Z wrote: > > Set the KCR init during the boot time, which is > > required by hardware, to allow us doing further > > protection operation such as sending commands to > > GPU or TEE. > > > > Signed-off-by: Huang, Sean Z <sean.z.huang@xxxxxxxxx> > > --- > > drivers/gpu/drm/i915/pxp/intel_pxp.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp.c > > b/drivers/gpu/drm/i915/pxp/intel_pxp.c > > index 9bc3c7e30654..f566a4fda044 100644 > > --- a/drivers/gpu/drm/i915/pxp/intel_pxp.c > > +++ b/drivers/gpu/drm/i915/pxp/intel_pxp.c > > @@ -6,6 +6,12 @@ > > #include "intel_pxp.h" > > #include "intel_pxp_context.h" > > > > +/* KCR register definitions */ > > please define this in i915_reg.h Generally the trend on the GT side is to contain in a .c file if there are no shared users like these. So they should be at this spot, yet the rest of the review comments apply. The spurious comments should be dropped and like Rodrigo pointed out, we should be using the appropriate macros for a masked writes, not baking in the #define. Regards, Joonas _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
