On Wed, 2021-01-06 at 23:47 +0000, Patchwork wrote: > == Series Details == > > Series: Introduce Intel PXP component - Mesa single session (rev19) > URL : https://patchwork.freedesktop.org/series/84620/ > State : warning > > == Summary == > > $ dim checkpatch origin/drm-tip > fbdd4e2e287d drm/i915/pxp: Introduce Intel PXP component > -:119: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), > does MAINTAINERS need updating? > #119: > new file mode 100644 > > total: 0 errors, 1 warnings, 0 checks, 194 lines checked > fdb764188c85 drm/i915/pxp: set KCR reg init during the boot time > 20c2f538fd26 drm/i915/pxp: Implement funcs to create the TEE channel > -:8: WARNING:TYPO_SPELLING: 'defualt' may be misspelled - perhaps > 'default'? > #8: > (defualt) session. > ^^^^^^^ > > -:85: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), > does MAINTAINERS need updating? > #85: > new file mode 100644 > > total: 0 errors, 2 warnings, 0 checks, 253 lines checked > e77ddc43854a drm/i915/pxp: Create the arbitrary session after boot > -:68: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), > does MAINTAINERS need updating? > #68: > new file mode 100644 > > total: 0 errors, 1 warnings, 0 checks, 330 lines checked > 60d904942ebb drm/i915/pxp: Func to send hardware session termination > -:53: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), > does MAINTAINERS need updating? > #53: > new file mode 100644 > > total: 0 errors, 1 warnings, 0 checks, 222 lines checked > e06c62d5fd8d drm/i915/pxp: Enable PXP irq worker and callback stub > -:51: WARNING:LONG_LINE_COMMENT: line length of 113 exceeds 100 > columns > #51: FILE: drivers/gpu/drm/i915/i915_reg.h:7970: > +#define GEN11_CRYPTO_INTR_MASK _MMIO(0x1900f0) /* crypto > mask is in bit31-16 (Engine1 Interrupt Mask) */ > > total: 0 errors, 1 warnings, 0 checks, 230 lines checked > 2b451866410d drm/i915/pxp: Destroy arb session upon teardown > f74cff978a9a drm/i915/pxp: Enable PXP power management > -:78: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), > does MAINTAINERS need updating? > #78: > new file mode 100644 > > total: 0 errors, 1 warnings, 0 checks, 148 lines checked > f45f6bf27787 drm/i915/pxp: Expose session state for display > protection flip > ed1733ee9985 mei: pxp: export pavp client to me client bus > -:32: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), > does MAINTAINERS need updating? > #32: > new file mode 100644 > > total: 0 errors, 1 warnings, 0 checks, 277 lines checked > 5ed5ea72d630 drm/i915/uapi: introduce drm_i915_gem_create_ext > -:12: ERROR:BAD_SIGN_OFF: Unrecognized email address: 'Joonas > Lahtinen joonas.lahtinen@xxxxxxxxxxxxxxx' > #12: > Cc: Joonas Lahtinen joonas.lahtinen@xxxxxxxxxxxxxxx Please make sure you address some of the checkpatch complains like this > > -:13: ERROR:BAD_SIGN_OFF: Unrecognized email address: 'Matthew Auld > matthew.auld@xxxxxxxxx' > #13: > Cc: Matthew Auld matthew.auld@xxxxxxxxx this > > -:46: ERROR:CODE_INDENT: code indent should use tabs where possible > #46: FILE: drivers/gpu/drm/i915/i915_gem.c:265: > + struct drm_i915_private *i915;$ this > > -:46: WARNING:LEADING_SPACE: please, no spaces at the start of a line > #46: FILE: drivers/gpu/drm/i915/i915_gem.c:265: > + struct drm_i915_private *i915;$ > this > -:50: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open > parenthesis > #50: FILE: drivers/gpu/drm/i915/i915_gem.c:269: > +static int __create_setparam(struct drm_i915_gem_object_param *args, > + struct > create_ext *ext_data) > this > -:95: CHECK:LINE_SPACING: Please don't use multiple blank lines > #95: FILE: drivers/gpu/drm/i915/i915_gem.c:317: > + > + this > -:107: WARNING:LONG_LINE: line length of 120 exceeds 100 columns > #107: FILE: include/uapi/drm/i915_drm.h:395: > +#define DRM_IOCTL_I915_GEM_CREATE_EXT DRM_IOWR(DRM_COMMAND_BASE + > DRM_I915_GEM_CREATE, struct drm_i915_gem_create_ext) > > -:155: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) > #155: FILE: include/uapi/drm/i915_drm.h:1736: > +#define I915_OBJECT_PARAM (1ull<<32) this > ^ > > total: 3 errors, 2 warnings, 3 checks, 136 lines checked > ae1f0edf901f drm/i915/pxp: User interface for Protected buffer > 7ce48b165a12 drm/i915/pxp: Add plane decryption support > > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx