On Wed, Dec 16, 2020 at 12:03:37PM +0200, Jani Nikula wrote: > On Fri, 11 Dec 2020, Dave Airlie <airlied@xxxxxxxxx> wrote: > > From: Dave Airlie <airlied@xxxxxxxxxx> > > > > There may be more crtc code that can be pulled out, but this > > is a good start. > > > > RFC: maybe call the new file something different > > I checked this is just code movement. I did clean up intel_crtc.h > locally a bit though. (I'll probably re-send the series with a few fixes > to pass CI.) > > I'm not averse to renaming the file later if needed, I'm more concerned > about choosing a meaningful bunch of functions to take out and put in > the new file. > > Ville, I saw you had some comments about this - is this making sensible > progress or making further refactoring harder? Just means we have to move 90% of the proposed intel_crtc.c into i9xx_plane.c again. So the plane bits here are just pointless churn IMO. -- Ville Syrjälä Intel --------------------------------------------------------------------- Intel Finland Oy Registered Address: PL 281, 00181 Helsinki Business Identity Code: 0357606 - 4 Domiciled in Helsinki This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
