This is Dave's intel_display.c refactoring series [1] with some minor issues addressed, to get CI results among other things. I've reviewed and fixed any remaining minor issues I spotted in patches 1-8. I'm aware there may be things to improve, but I think this is overall forward progress and cleanup that's long overdue. I'm prepared to merge patches 1-8 unless there are strong objections. I ran out of steam a little with patches 9-11, and haven't reviewed them. They're included here just for completeness. BR, Jani. [1] https://patchwork.freedesktop.org/series/84812/ Dave Airlie (11): drm/i915/display: move needs_modeset to an inline in header drm/i915/display: move to_intel_frontbuffer to header drm/i915/display: fix misused comma drm/i915: refactor cursor code out of i915_display.c drm/i915: refactor some crtc code out of intel display. drm/i915: refactor pll code out into intel_dpll.c drm/i915: split fdi code out from intel_display.c drm/i915: migrate hsw fdi code to new file. drm/i915: migrate skl planes code new file drm/i915: move pipe update code into crtc. drm/i915: split fb scalable checks into g4x and skl versions drivers/gpu/drm/i915/Makefile | 5 + .../gpu/drm/i915/display/intel_atomic_plane.c | 76 - drivers/gpu/drm/i915/display/intel_crt.c | 1 + drivers/gpu/drm/i915/display/intel_crtc.c | 1187 + drivers/gpu/drm/i915/display/intel_crtc.h | 22 + drivers/gpu/drm/i915/display/intel_cursor.c | 806 + drivers/gpu/drm/i915/display/intel_cursor.h | 17 + drivers/gpu/drm/i915/display/intel_ddi.c | 197 +- drivers/gpu/drm/i915/display/intel_ddi.h | 14 +- drivers/gpu/drm/i915/display/intel_display.c | 20019 ++++++---------- drivers/gpu/drm/i915/display/intel_display.h | 46 +- .../drm/i915/display/intel_display_types.h | 55 + drivers/gpu/drm/i915/display/intel_dpll.c | 1363 ++ drivers/gpu/drm/i915/display/intel_dpll.h | 23 + drivers/gpu/drm/i915/display/intel_fdi.c | 857 + drivers/gpu/drm/i915/display/intel_fdi.h | 29 + .../gpu/drm/i915/display/intel_gen9_plane.c | 2832 +++ drivers/gpu/drm/i915/display/intel_sprite.c | 1712 +- 18 files changed, 14739 insertions(+), 14522 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/intel_crtc.c create mode 100644 drivers/gpu/drm/i915/display/intel_crtc.h create mode 100644 drivers/gpu/drm/i915/display/intel_cursor.c create mode 100644 drivers/gpu/drm/i915/display/intel_cursor.h create mode 100644 drivers/gpu/drm/i915/display/intel_dpll.c create mode 100644 drivers/gpu/drm/i915/display/intel_dpll.h create mode 100644 drivers/gpu/drm/i915/display/intel_fdi.c create mode 100644 drivers/gpu/drm/i915/display/intel_fdi.h create mode 100644 drivers/gpu/drm/i915/display/intel_gen9_plane.c -- 2.20.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx