Re: [PATCH] drm/i915: Try to guess PCH type even without ISA bridge

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Xiong,

I love your patch! Perhaps something to improve:

[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on drm-tip/drm-tip v5.10 next-20201211]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Xiong-Zhang/drm-i915-Try-to-guess-PCH-type-even-without-ISA-bridge/20201214-150157
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-randconfig-a002-20201214 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project d38205144febf4dc42c9270c6aa3d978f1ef65e1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://github.com/0day-ci/linux/commit/718272991fa5c06a48629bce020ecfbdea006f96
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Xiong-Zhang/drm-i915-Try-to-guess-PCH-type-even-without-ISA-bridge/20201214-150157
        git checkout 718272991fa5c06a48629bce020ecfbdea006f96
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/i915/intel_pch.c:187:6: warning: no previous prototype for function 'intel_detect_pch_virt' [-Wmissing-prototypes]
   void intel_detect_pch_virt(struct drm_i915_private *dev_priv)
        ^
   drivers/gpu/drm/i915/intel_pch.c:187:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void intel_detect_pch_virt(struct drm_i915_private *dev_priv)
   ^
   static 
   1 warning generated.

vim +/intel_detect_pch_virt +187 drivers/gpu/drm/i915/intel_pch.c

   186	
 > 187	void intel_detect_pch_virt(struct drm_i915_private *dev_priv)
   188	{
   189		unsigned short id;
   190		enum intel_pch pch_type;
   191	
   192		id = intel_virt_detect_pch(dev_priv);
   193		pch_type = intel_pch_type(dev_priv, id);
   194	
   195		/* Sanity check virtual PCH id */
   196		if (drm_WARN_ON(&dev_priv->drm,
   197				id && pch_type == PCH_NONE))
   198			id = 0;
   199	
   200		dev_priv->pch_type = pch_type;
   201		dev_priv->pch_id = id;
   202	}
   203	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux