== Series Details == Series: Introduce Intel PXP component - Mesa single session (rev6) URL : https://patchwork.freedesktop.org/series/84620/ State : warning == Summary == $ dim checkpatch origin/drm-tip 483cb19f6248 drm/i915/pxp: Introduce Intel PXP component -:111: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #111: new file mode 100644 total: 0 errors, 1 warnings, 0 checks, 175 lines checked b12972ae3297 drm/i915/pxp: set KCR reg init during the boot time cb091c29444b drm/i915/pxp: Implement funcs to create the TEE channel -:8: WARNING:TYPO_SPELLING: 'defualt' may be misspelled - perhaps 'default'? #8: (defualt) session. -:85: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #85: new file mode 100644 total: 0 errors, 2 warnings, 0 checks, 248 lines checked 1269b2f4bf9b drm/i915/pxp: Create the arbitrary session after boot -:68: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #68: new file mode 100644 total: 0 errors, 1 warnings, 0 checks, 297 lines checked 6e0495763e2b drm/i915/pxp: Func to send hardware session termination -:25: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #25: new file mode 100644 total: 0 errors, 1 warnings, 0 checks, 181 lines checked e1072de8779e drm/i915/pxp: Enable PXP irq worker and callback stub -:51: WARNING:LONG_LINE_COMMENT: line length of 113 exceeds 100 columns #51: FILE: drivers/gpu/drm/i915/i915_reg.h:7970: +#define GEN11_CRYPTO_INTR_MASK _MMIO(0x1900f0) /* crypto mask is in bit31-16 (Engine1 Interrupt Mask) */ total: 0 errors, 1 warnings, 0 checks, 210 lines checked 4243dda12065 drm/i915/pxp: Destroy arb session upon teardown 1cc947ef42df drm/i915/pxp: Enable PXP power management -:90: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #90: new file mode 100644 total: 0 errors, 1 warnings, 0 checks, 148 lines checked c78a877702c7 drm/i915/pxp: Expose session state for display protection flip d2ed1fac0c2c mei: pxp: export pavp client to me client bus -:32: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #32: new file mode 100644 total: 0 errors, 1 warnings, 0 checks, 277 lines checked 238291470e9d drm/i915/uapi: introduce drm_i915_gem_create_ext -:12: ERROR:BAD_SIGN_OFF: Unrecognized email address: 'Joonas Lahtinen joonas.lahtinen@xxxxxxxxxxxxxxx' #12: Cc: Joonas Lahtinen joonas.lahtinen@xxxxxxxxxxxxxxx -:13: ERROR:BAD_SIGN_OFF: Unrecognized email address: 'Matthew Auld matthew.auld@xxxxxxxxx' #13: Cc: Matthew Auld matthew.auld@xxxxxxxxx -:46: ERROR:CODE_INDENT: code indent should use tabs where possible #46: FILE: drivers/gpu/drm/i915/i915_gem.c:265: + struct drm_i915_private *i915;$ -:46: WARNING:LEADING_SPACE: please, no spaces at the start of a line #46: FILE: drivers/gpu/drm/i915/i915_gem.c:265: + struct drm_i915_private *i915;$ -:50: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #50: FILE: drivers/gpu/drm/i915/i915_gem.c:269: +static int __create_setparam(struct drm_i915_gem_object_param *args, + struct create_ext *ext_data) -:95: CHECK:LINE_SPACING: Please don't use multiple blank lines #95: FILE: drivers/gpu/drm/i915/i915_gem.c:317: + + -:107: WARNING:LONG_LINE: line length of 120 exceeds 100 columns #107: FILE: include/uapi/drm/i915_drm.h:394: +#define DRM_IOCTL_I915_GEM_CREATE_EXT DRM_IOWR(DRM_COMMAND_BASE + DRM_I915_GEM_CREATE, struct drm_i915_gem_create_ext) -:155: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #155: FILE: include/uapi/drm/i915_drm.h:1735: +#define I915_OBJECT_PARAM (1ull<<32) ^ total: 3 errors, 2 warnings, 3 checks, 136 lines checked 9d0636e9498a drm/i915/pxp: User interface for Protected buffer 6b8e71a51390 drm/i915/pxp: Add plane decryption support 717f710b867c drm/i915/pxp: Implement ioctl action to reserve session slots -:62: WARNING:PREFER_PACKED: __packed is preferred over __attribute__((packed)) #62: FILE: drivers/gpu/drm/i915/pxp/intel_pxp.c:39: +} __attribute__((packed)); -:254: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #254: new file mode 100644 -:345: WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst #345: FILE: drivers/gpu/drm/i915/pxp/intel_pxp_sm.c:87: + msleep(10); total: 0 errors, 3 warnings, 0 checks, 437 lines checked cd05c940fecf drm/i915/pxp: Implement ioctl action to set session in play f2c7fba3da45 drm/i915/pxp: Implement ioctl action to terminate the session 733af51aac06 drm/i915/pxp: Implement ioctl action to send TEE commands e9386b8ba7be drm/i915/pxp: Implement ioctl action to query PXP tag 611b466b4273 drm/i915/pxp: Termiante the session upon app crash 2d36ea7befb9 drm/i915/pxp: Add PXP-related registers into allowlist c5cb8520b5e1 drm/i915/pxp: Enable the PXP ioctl for protected session -:9: WARNING:TYPO_SPELLING: 'destory' may be misspelled - perhaps 'destroy'? #9: destory the protected session via this ioctl. -:105: WARNING:LONG_LINE: line length of 110 exceeds 100 columns #105: FILE: include/uapi/drm/i915_drm.h:427: +#define DRM_IOCTL_I915_PXP_OPS DRM_IOWR(DRM_COMMAND_BASE + DRM_I915_PXP_OPS, struct drm_i915_pxp_ops) total: 0 errors, 2 warnings, 0 checks, 156 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx