✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add support for Intel's eDP backlight controls (rev4)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



== Series Details ==

Series: drm/i915: Add support for Intel's eDP backlight controls (rev4)
URL   : https://patchwork.freedesktop.org/series/81702/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
d5d9ce10b038 drm/i915/dp: Program source OUI on eDP panels
512d305a2664 drm/i915: Rename pwm_* backlight callbacks to ext_pwm_*
67aeac3f4a13 drm/i915: Pass down brightness values to enable/disable backlight callbacks
a0b1c9f85b6d drm/i915: Keep track of pwm-related backlight hooks separately
d2b61f334725 drm/i915/dp: Rename eDP VESA backlight interface functions
a39270383236 drm/i915/dp: Add register definitions for Intel HDR backlight interface
9a7fd4a45094 drm/i915/dp: Enable Intel's HDR backlight interface (only SDR for now)
-:151: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#151: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:147:
+			return panel->backlight.max;
+		} else {

-:172: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u8' over 'uint8_t'
#172: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:168:
+	uint8_t buf[4] = { 0 };

-:191: WARNING:LINE_SPACING: Missing a blank line after declarations
#191: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:187:
+		const u32 pwm_level = intel_panel_backlight_level_to_pwm(connector, level);
+		intel_panel_set_pwm_level(conn_state, pwm_level);

-:218: WARNING:LINE_SPACING: Missing a blank line after declarations
#218: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:214:
+		u32 pwm_level = intel_panel_backlight_level_to_pwm(connector, level);
+		panel->backlight.pwm_funcs->enable(crtc_state, conn_state, pwm_level);

total: 0 errors, 3 warnings, 1 checks, 379 lines checked
d6f6f3fa825f drm/i915/dp: Allow forcing specific interfaces through enable_dpcd_backlight
b5315912cc7f drm/dp: Revert "drm/dp: Introduce EDID-based quirks"


_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx



[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux