== Series Details == Series: drm/i915/debugfs : PM_REQ and PM_RES register debugfs URL : https://patchwork.freedesktop.org/series/84782/ State : warning == Summary == $ dim checkpatch origin/drm-tip b23f408141a8 drm/i915/debugfs : PM_REQ and PM_RES register debugfs -:7: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #7: Display Engine.PM_RES register provides the value of the last PM response from -:25: ERROR:CODE_INDENT: code indent should use tabs where possible #25: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:564: + struct drm_i915_private *dev_priv = node_to_i915(m->private);$ -:25: WARNING:LEADING_SPACE: please, no spaces at the start of a line #25: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:564: + struct drm_i915_private *dev_priv = node_to_i915(m->private);$ -:26: ERROR:CODE_INDENT: code indent should use tabs where possible #26: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:565: + struct intel_csr *csr = &dev_priv->csr;$ -:26: WARNING:LEADING_SPACE: please, no spaces at the start of a line #26: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:565: + struct intel_csr *csr = &dev_priv->csr;$ -:28: ERROR:CODE_INDENT: code indent should use tabs where possible #28: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:567: + if (!HAS_CSR(dev_priv))$ -:28: WARNING:LEADING_SPACE: please, no spaces at the start of a line #28: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:567: + if (!HAS_CSR(dev_priv))$ -:29: ERROR:CODE_INDENT: code indent should use tabs where possible #29: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:568: + return -ENODEV;$ -:29: WARNING:LEADING_SPACE: please, no spaces at the start of a line #29: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:568: + return -ENODEV;$ -:31: ERROR:CODE_INDENT: code indent should use tabs where possible #31: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:570: + if (!csr->dmc_payload)$ -:31: WARNING:LEADING_SPACE: please, no spaces at the start of a line #31: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:570: + if (!csr->dmc_payload)$ -:32: ERROR:CODE_INDENT: code indent should use tabs where possible #32: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:571: + return 0;$ -:32: WARNING:LEADING_SPACE: please, no spaces at the start of a line #32: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:571: + return 0;$ -:34: ERROR:CODE_INDENT: code indent should use tabs where possible #34: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:573: + seq_printf(m, "PM debug request 0 (0x45284) : 0x%x\n",$ -:34: WARNING:LEADING_SPACE: please, no spaces at the start of a line #34: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:573: + seq_printf(m, "PM debug request 0 (0x45284) : 0x%x\n",$ -:35: ERROR:CODE_INDENT: code indent should use tabs where possible #35: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:574: + intel_de_read(dev_priv, PM_REQ_DBG_0));$ -:35: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #35: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:574: + seq_printf(m, "PM debug request 0 (0x45284) : 0x%x\n", + intel_de_read(dev_priv, PM_REQ_DBG_0)); -:35: WARNING:LEADING_SPACE: please, no spaces at the start of a line #35: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:574: + intel_de_read(dev_priv, PM_REQ_DBG_0));$ -:36: ERROR:CODE_INDENT: code indent should use tabs where possible #36: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:575: + seq_printf(m, "PM debug request 1 (0x45288) : 0x%x\n",$ -:36: WARNING:LEADING_SPACE: please, no spaces at the start of a line #36: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:575: + seq_printf(m, "PM debug request 1 (0x45288) : 0x%x\n",$ -:37: ERROR:CODE_INDENT: code indent should use tabs where possible #37: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:576: + intel_de_read(dev_priv, PM_REQ_DBG_1));$ -:37: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #37: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:576: + seq_printf(m, "PM debug request 1 (0x45288) : 0x%x\n", + intel_de_read(dev_priv, PM_REQ_DBG_1)); -:37: WARNING:LEADING_SPACE: please, no spaces at the start of a line #37: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:576: + intel_de_read(dev_priv, PM_REQ_DBG_1));$ -:38: ERROR:CODE_INDENT: code indent should use tabs where possible #38: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:577: + seq_printf(m, "PM debug response 0 (0x4528C) : 0x%x\n",$ -:38: WARNING:LEADING_SPACE: please, no spaces at the start of a line #38: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:577: + seq_printf(m, "PM debug response 0 (0x4528C) : 0x%x\n",$ -:39: ERROR:CODE_INDENT: code indent should use tabs where possible #39: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:578: + intel_de_read(dev_priv, PM_RSP_DBG_0));$ -:39: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #39: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:578: + seq_printf(m, "PM debug response 0 (0x4528C) : 0x%x\n", + intel_de_read(dev_priv, PM_RSP_DBG_0)); -:39: WARNING:LEADING_SPACE: please, no spaces at the start of a line #39: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:578: + intel_de_read(dev_priv, PM_RSP_DBG_0));$ -:40: ERROR:CODE_INDENT: code indent should use tabs where possible #40: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:579: + seq_printf(m, "PM debug response 1 (0x45290) : 0x%x\n",$ -:40: WARNING:LEADING_SPACE: please, no spaces at the start of a line #40: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:579: + seq_printf(m, "PM debug response 1 (0x45290) : 0x%x\n",$ -:41: ERROR:CODE_INDENT: code indent should use tabs where possible #41: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:580: + intel_de_read(dev_priv, PM_RSP_DBG_1));$ -:41: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #41: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:580: + seq_printf(m, "PM debug response 1 (0x45290) : 0x%x\n", + intel_de_read(dev_priv, PM_RSP_DBG_1)); -:41: WARNING:LEADING_SPACE: please, no spaces at the start of a line #41: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:580: + intel_de_read(dev_priv, PM_RSP_DBG_1));$ -:43: ERROR:CODE_INDENT: code indent should use tabs where possible #43: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:582: + return 0;$ -:43: WARNING:LEADING_SPACE: please, no spaces at the start of a line #43: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:582: + return 0;$ -:66: WARNING:SPACE_BEFORE_TAB: please, no space before tabs #66: FILE: drivers/gpu/drm/i915/i915_reg.h:375: +#define PM_REQ_DBG_1 ^I^I_MMIO(0x45288)$ -:67: WARNING:SPACE_BEFORE_TAB: please, no space before tabs #67: FILE: drivers/gpu/drm/i915/i915_reg.h:376: +#define PM_RSP_DBG_0 ^I^I_MMIO(0x4528C)$ -:68: WARNING:SPACE_BEFORE_TAB: please, no space before tabs #68: FILE: drivers/gpu/drm/i915/i915_reg.h:377: +#define PM_RSP_DBG_1 ^I^I_MMIO(0x45290)$ total: 15 errors, 19 warnings, 4 checks, 47 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
