Re: [PATCH i-g-t 2/2] i915/query: Directly check query results against GETPARAM

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 08/12/2020 11:04, Petri Latvala wrote:
On Mon, Dec 07, 2020 at 04:11:50PM +0000, Chris Wilson wrote:
Simplify the cross-check by asserting that the existence of an engine in
the list matches the existence of the engine as reported by GETPARAM.
By using the comparison, we check both directions at once.

Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
Cc: Petri Latvala <petri.latvala@xxxxxxxxx>


For the series,
Reviewed-by: Petri Latvala <petri.latvala@xxxxxxxxx>

Yeah it's a yes from me as well. Either test was merged with or before the engine map feature so it had to be a bit more backward compatible.

I wonder at which point we re-implement gem_has_xcs family to use the query and move the get_param based tests to a single legacy test.

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx



[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux