On Wed, 6 Mar 2013 20:05:59 +0100 Daniel Vetter <daniel at ffwll.ch> wrote: > On Fri, Mar 01, 2013 at 01:14:31PM -0800, Jesse Barnes wrote: > > Allows us to detect eDP panels that may not have the hotplug pin wired up. > > > > Signed-off-by: Jesse Barnes <jbarnes at virtuousgeek.org> > > Historically the lid status is horribly broken which is why it's disabled > by default. What changed to now enable it unconditionally? Is this a > requirement on vlv? > -Daniel > > > --- > > drivers/gpu/drm/i915/intel_dp.c | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c > > index 05e1000..c127cb7 100644 > > --- a/drivers/gpu/drm/i915/intel_dp.c > > +++ b/drivers/gpu/drm/i915/intel_dp.c > > @@ -2413,6 +2413,16 @@ g4x_dp_detect(struct intel_dp *intel_dp) > > struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp); > > uint32_t bit; > > > > + /* Can't disconnect eDP, but you can close the lid... */ > > + if (is_edp(intel_dp)) { > > + enum drm_connector_status status; > > + > > + status = intel_panel_detect(dev); > > + if (status == connector_status_unknown) > > + status = connector_status_connected; > > + return status; > > + } > > + Well this doesn't touch the panel_detect() stuff at all, where we have the hacks to avoid using _LID... -- Jesse Barnes, Intel Open Source Technology Center