== Series Details == Series: Introduce Intel PXP component (rev4) URL : https://patchwork.freedesktop.org/series/84136/ State : warning == Summary == $ dim checkpatch origin/drm-tip 3ce53f7dc704 drm/i915/pxp: Introduce Intel PXP component -:108: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #108: new file mode 100644 total: 0 errors, 1 warnings, 0 checks, 125 lines checked b069e4460363 drm/i915/pxp: Enable PXP irq worker and callback stub 9d93e3de599a drm/i915/pxp: Add PXP context for logical hardware states. -:106: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #106: new file mode 100644 total: 0 errors, 1 warnings, 0 checks, 165 lines checked ac644173c4a0 drm/i915/pxp: set KCR reg init during the boot time -:69: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #69: new file mode 100644 total: 0 errors, 1 warnings, 0 checks, 102 lines checked ea5b0b6c33c2 drm/i915/pxp: Implement ioctl action to set the user space context -:109: WARNING:PREFER_PACKED: __packed is preferred over __attribute__((packed)) #109: FILE: drivers/gpu/drm/i915/pxp/intel_pxp.h:40: +} __attribute__((packed)); total: 0 errors, 1 warnings, 0 checks, 147 lines checked b2bf2b5d0e5c drm/i915/pxp: Add PXP-related registers into allowlist 791a4cc06927 drm/i915/pxp: Read register to check hardware session state -:19: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #19: FILE: drivers/gpu/drm/i915/pxp/intel_pxp.h:15: +#define pxp_session_list(i915, session_type) (((session_type) == SESSION_TYPE_TYPE0) ? \ + &(i915)->pxp.ctx->active_pxp_type0_sessions : &(i915)->pxp.ctx->active_pxp_type1_sessions) total: 0 errors, 0 warnings, 1 checks, 255 lines checked 80f5b789b7aa drm/i915/pxp: Implement funcs to get/set PXP tag 89660e95826a drm/i915/pxp: Implement ioctl action to reserve session slot 4e64444547d5 drm/i915/pxp: Implement ioctl action to set session in play a50087361687 drm/i915/pxp: Func to send hardware session termination 5c9dfa8888d1 drm/i915/pxp: Implement ioctl action to terminate the session 260be06ba629 drm/i915/pxp: Enable ioctl action to query PXP tag 789007105c02 drm/i915/pxp: Destroy all type0 sessions upon teardown 99e9bd56cb87 drm/i915/pxp: Termiante the session upon app crash db542427db49 drm/i915/pxp: Enable PXP power management -:67: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #67: new file mode 100644 total: 0 errors, 1 warnings, 0 checks, 142 lines checked 62932c88f944 drm/i915/pxp: Implement funcs to create the TEE channel -:87: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #87: new file mode 100644 total: 0 errors, 1 warnings, 0 checks, 244 lines checked 87ef8cfabefd drm/i915/pxp: Implement ioctl action to send TEE commands 0328e28c02df drm/i915/pxp: Create the arbitrary session after boot 3f8d34287fc8 drm/i915/pxp: Add i915 trace logs for PXP operations -:11: WARNING:TYPO_SPELLING: 'trun' may be misspelled - perhaps 'turn'? #11: To trun on this feature, we need to set -:29: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #29: FILE: drivers/gpu/drm/i915/i915_trace.h:1038: + TP_STRUCT__entry( -:36: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #36: FILE: drivers/gpu/drm/i915/i915_trace.h:1045: + TP_fast_assign( total: 0 errors, 1 warnings, 2 checks, 80 lines checked 0c225361f287 drm/i915/pxp: Expose session state for display protection flip 3f9d21975353 mei: pxp: export pavp client to me client bus -:32: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #32: new file mode 100644 total: 0 errors, 1 warnings, 0 checks, 277 lines checked b730c330356d drm/i915/uapi: introduce drm_i915_gem_create_ext -:12: ERROR:BAD_SIGN_OFF: Unrecognized email address: 'Joonas Lahtinen joonas.lahtinen@xxxxxxxxxxxxxxx' #12: Cc: Joonas Lahtinen joonas.lahtinen@xxxxxxxxxxxxxxx -:13: ERROR:BAD_SIGN_OFF: Unrecognized email address: 'Matthew Auld matthew.auld@xxxxxxxxx' #13: Cc: Matthew Auld matthew.auld@xxxxxxxxx -:46: ERROR:CODE_INDENT: code indent should use tabs where possible #46: FILE: drivers/gpu/drm/i915/i915_gem.c:265: + struct drm_i915_private *i915;$ -:46: WARNING:LEADING_SPACE: please, no spaces at the start of a line #46: FILE: drivers/gpu/drm/i915/i915_gem.c:265: + struct drm_i915_private *i915;$ -:50: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #50: FILE: drivers/gpu/drm/i915/i915_gem.c:269: +static int __create_setparam(struct drm_i915_gem_object_param *args, + struct create_ext *ext_data) -:95: CHECK:LINE_SPACING: Please don't use multiple blank lines #95: FILE: drivers/gpu/drm/i915/i915_gem.c:317: + + -:107: WARNING:LONG_LINE: line length of 120 exceeds 100 columns #107: FILE: include/uapi/drm/i915_drm.h:394: +#define DRM_IOCTL_I915_GEM_CREATE_EXT DRM_IOWR(DRM_COMMAND_BASE + DRM_I915_GEM_CREATE, struct drm_i915_gem_create_ext) -:155: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #155: FILE: include/uapi/drm/i915_drm.h:1735: +#define I915_OBJECT_PARAM (1ull<<32) ^ total: 3 errors, 2 warnings, 3 checks, 136 lines checked afcf0d8a5ee0 drm/i915/pxp: User interface for Protected buffer 6de7943d6605 drm/i915/pxp: Add plane decryption support 71c5f649a82e drm/i915/pxp: Enable the PXP ioctl for protected session -:9: WARNING:TYPO_SPELLING: 'destory' may be misspelled - perhaps 'destroy'? #9: destory the protected session via this ioctl. -:100: WARNING:LONG_LINE: line length of 110 exceeds 100 columns #100: FILE: include/uapi/drm/i915_drm.h:427: +#define DRM_IOCTL_I915_PXP_OPS DRM_IOWR(DRM_COMMAND_BASE + DRM_I915_PXP_OPS, struct drm_i915_pxp_ops) total: 0 errors, 2 warnings, 0 checks, 154 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx