On 2020.12.01 18:16:35 +0200, Jani Nikula wrote:
> On Mon, 30 Nov 2020, Jani Nikula <jani.nikula@xxxxxxxxx> wrote:
> > Let's avoid adding new I915_WRITE uses while we try to get rid of them.
> >
> > Fixes: 5f60b12edcd0 ("drm/i915/gvt: Save/restore HW status to support GVT suspend/resume")
> > Cc: Zhenyu Wang <zhenyuw@xxxxxxxxxxxxxxx>
> > Cc: Hang Yuan <hang.yuan@xxxxxxxxxxxxxxx>
> > Cc: Colin Xu <colin.xu@xxxxxxxxx>
> > Cc: Zhi Wang <zhi.a.wang@xxxxxxxxx>
> > Cc: intel-gvt-dev@xxxxxxxxxxxxxxxxxxxxx
> > Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx>
>
> Pushed up to, but *excluding* this patch to dinq. Thanks for the
> reviews.
>
> Zhenyu, Zhi, may I have your review/ack for merging this one directly
> via dinq to not add a dependency on the gvt tree?
>
Yep, that's fine to me.
Reviewed-by: Zhenyu Wang <zhenyuw@xxxxxxxxxxxxxxx>
>
> BR,
> Jani.
>
>
> > ---
> > drivers/gpu/drm/i915/gvt/handlers.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/gvt/handlers.c b/drivers/gpu/drm/i915/gvt/handlers.c
> > index 6f0706e885cb..eba626ba640f 100644
> > --- a/drivers/gpu/drm/i915/gvt/handlers.c
> > +++ b/drivers/gpu/drm/i915/gvt/handlers.c
> > @@ -3693,7 +3693,7 @@ static inline int mmio_pm_restore_handler(struct intel_gvt *gvt,
> > struct drm_i915_private *dev_priv = gvt->gt->i915;
> >
> > if (gvt->mmio.mmio_attribute[offset >> 2] & F_PM_SAVE)
> > - I915_WRITE(_MMIO(offset), vgpu_vreg(vgpu, offset));
> > + intel_uncore_write(&dev_priv->uncore, _MMIO(offset), vgpu_vreg(vgpu, offset));
> >
> > return 0;
> > }
>
> --
> Jani Nikula, Intel Open Source Graphics Center
--
$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
