== Series Details == Series: series starting with [v3,1/5] drm/i915/display/psr: Calculate selective fetch plane registers URL : https://patchwork.freedesktop.org/series/84340/ State : warning == Summary == $ dim checkpatch origin/drm-tip 0519f1c556bc drm/i915/display/psr: Calculate selective fetch plane registers a394d94d01f2 drm/i915/display/psr: Calculate Trancoder's SU rect and plane's SF rect -:42: WARNING:LONG_LINE: line length of 109 exceeds 100 columns #42: FILE: drivers/gpu/drm/i915/display/intel_display.h:468: +#define for_each_oldnew_intel_plane_in_state_reverse(__state, plane, old_plane_state, new_plane_state, __i) \ -:42: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__state' - possible side-effects? #42: FILE: drivers/gpu/drm/i915/display/intel_display.h:468: +#define for_each_oldnew_intel_plane_in_state_reverse(__state, plane, old_plane_state, new_plane_state, __i) \ + for ((__i) = (__state)->base.dev->mode_config.num_total_plane - 1; \ + (__i) >= 0 && \ + ((plane) = to_intel_plane((__state)->base.planes[__i].ptr), \ + (old_plane_state) = to_intel_plane_state((__state)->base.planes[__i].old_state), \ + (new_plane_state) = to_intel_plane_state((__state)->base.planes[__i].new_state), 1); \ + (__i)--) \ + for_each_if(plane) -:42: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'plane' - possible side-effects? #42: FILE: drivers/gpu/drm/i915/display/intel_display.h:468: +#define for_each_oldnew_intel_plane_in_state_reverse(__state, plane, old_plane_state, new_plane_state, __i) \ + for ((__i) = (__state)->base.dev->mode_config.num_total_plane - 1; \ + (__i) >= 0 && \ + ((plane) = to_intel_plane((__state)->base.planes[__i].ptr), \ + (old_plane_state) = to_intel_plane_state((__state)->base.planes[__i].old_state), \ + (new_plane_state) = to_intel_plane_state((__state)->base.planes[__i].new_state), 1); \ + (__i)--) \ + for_each_if(plane) -:42: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i' - possible side-effects? #42: FILE: drivers/gpu/drm/i915/display/intel_display.h:468: +#define for_each_oldnew_intel_plane_in_state_reverse(__state, plane, old_plane_state, new_plane_state, __i) \ + for ((__i) = (__state)->base.dev->mode_config.num_total_plane - 1; \ + (__i) >= 0 && \ + ((plane) = to_intel_plane((__state)->base.planes[__i].ptr), \ + (old_plane_state) = to_intel_plane_state((__state)->base.planes[__i].old_state), \ + (new_plane_state) = to_intel_plane_state((__state)->base.planes[__i].new_state), 1); \ + (__i)--) \ + for_each_if(plane) -:46: WARNING:LONG_LINE: line length of 104 exceeds 100 columns #46: FILE: drivers/gpu/drm/i915/display/intel_display.h:472: + (old_plane_state) = to_intel_plane_state((__state)->base.planes[__i].old_state), \ -:47: WARNING:LONG_LINE: line length of 108 exceeds 100 columns #47: FILE: drivers/gpu/drm/i915/display/intel_display.h:473: + (new_plane_state) = to_intel_plane_state((__state)->base.planes[__i].new_state), 1); \ -:92: CHECK:LINE_SPACING: Please don't use multiple blank lines #92: FILE: drivers/gpu/drm/i915/display/intel_psr.c:1277: + + -:261: CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #261: FILE: drivers/gpu/drm/i915/display/intel_psr.c:1418: + new_plane_state, i) { + total: 0 errors, 3 warnings, 5 checks, 292 lines checked 6f2d0e56e996 drm/i915/display: Split and export main surface calculation from skl_check_main_surface() 4286e9f831a3 drm/i915/display/psr: Program Plane's calculated offset to Plane SF register 968a799d4c11 HAX/DO_NOT_MERGE_IT: drm/i915/display: Enable PSR2 selective fetch for testing _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx